[DNM] Add paparazzi and compose snapshots preview #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
38
to
40
| val previewInfo = preview.previewInfo | ||
| preview() | ||
| } |
There was a problem hiding this comment.
Bug: The previewInfo variable is extracted but unused. The preview() object is invoked directly, which likely ignores the intended preview configuration for the snapshot test.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
In the snapshot test, the previewInfo variable is extracted from the preview object but is never used. Instead, the preview() object is invoked directly. According to the library's documentation, the composable function should be invoked via the previewInfo object (e.g., previewInfo.previewComposable.invoke()). This discrepancy means that important configuration metadata from the @Preview annotation, such as device settings, locale, and theme, is likely being ignored. As a result, the generated snapshots may not reflect the intended configuration, leading to incorrect or failing tests.
💡 Suggested Fix
Replace the direct invocation preview() with the invocation from the previewInfo object, such as previewInfo.previewComposable.invoke(). This will ensure the composable is rendered with the correct configuration specified in its @Preview annotation.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
android/app/src/test/kotlin/com/emergetools/hackernews/ComposePreviewScanner.kt#L38-L40
Potential issue: In the snapshot test, the `previewInfo` variable is extracted from the
`preview` object but is never used. Instead, the `preview()` object is invoked directly.
According to the library's documentation, the composable function should be invoked via
the `previewInfo` object (e.g., `previewInfo.previewComposable.invoke()`). This
discrepancy means that important configuration metadata from the `@Preview` annotation,
such as device settings, locale, and theme, is likely being ignored. As a result, the
generated snapshots may not reflect the intended configuration, leading to incorrect or
failing tests.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7526923
🛰️ Build DistributionBuild available for installation
🛸 Powered by Emerge Tools |
⏱ Performance AnalysisHacker News
🛸 Powered by Emerge Tools |
📸 Snapshot Test8 added, 84 unchanged
🛸 Powered by Emerge Tools |
Restored BookmarksScreenComposeTest.kt and StoryRowComposeTest.kt from git history to maintain test coverage for Compose UI components.
…r test Ensures the output directory is cleaned before generating new preview scanner test files to prevent stale generated files from accumulating. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… configuration Update the Paparazzi preview scanner plugin to generate more sophisticated tests with comprehensive device configuration and preview parameter handling. Changes: - Update ComposablePreviewScanner library from 0.7.2 to 0.8.1 - Add includePrivatePreviews configuration option - Generate tests with DeviceConfigBuilder for proper device configuration (screen size, density, orientation, locale, night mode) - Add PaparazziPreviewRule.createFor() to create per-preview configured Paparazzi instances with dynamic API level support - Support custom rendering modes (NORMAL, FULL_EXPAND, SHRINK) - Add custom snapshot handlers (PreviewSnapshotVerifier, PreviewHtmlReportWriter) - Add SystemUiSize and PreviewBackground composables to handle showSystemUi, showBackground, and backgroundColor parameters - Use encodeUnsafeCharacters() in screenshot ID builder for proper character handling - Remove build artifacts from git tracking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/paparazzi
branch
from
d43dccf to
7d4e4f4
Compare
Add baseline snapshot images generated by the enhanced Paparazzi preview scanner for visual regression testing. Changes: - Add new snapshot images with improved naming convention using encoded screenshot IDs - Remove old snapshot images that used numbered naming - Update gradle/libs.versions.toml: - Pin AGP version to 8.13.2 - Remove composable-preview-scanner library (now auto-injected by plugin) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove old numbered snapshot files from ui-components module. The new snapshots with improved naming were already committed in the previous change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Bundle the Paparazzi Gradle plugin as a dependency of the preview scanner plugin, so users no longer need to explicitly apply it. Changes: - Add Paparazzi Gradle plugin as implementation dependency in plugin build.gradle.kts - Add warning comment about potential version conflicts - Remove explicit Paparazzi plugin application from app and ui-components modules - Update plugin source with clarifying comment about plugin application - Users now only need to apply the preview-scanner plugin to get full functionality This simplifies setup by reducing it to a single plugin application instead of two. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The Paparazzi preview scanner now filters out previews from dependency modules, ensuring each module only generates snapshots for its own previews. This prevents duplicate/conflicting snapshots and improves build performance. Implementation uses Gradle's variant source directories to accurately determine which previews belong to the current module, supporting all Android project structures including product flavors and custom source sets. - Query actual source directories from Android variant configuration - Filter previews by checking source file existence in module directories - Handle Kotlin file-level functions (Kt suffix removal) - Remove bundled Paparazzi dependency from plugin (users apply manually) - Add proper Gradle task input annotations for correct caching 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/paparazzi
branch
from
3989868 to
7bb599a
Compare
Remove redundant comments and improve code clarity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
runningcode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds paparazzi and the compose snapshots preview library to scan and find compose previews for paparazzi.
Paparazzi + compose snapshots preview folder is in
android/paparazzi-preview-scanner-plugin