Skip to content

Filter block entities by version support in ChunkDataPacket #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pingwiniu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Filter block entities by version support in ChunkDataPacket #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions plugin/src/main/java/net/elytrium/limboapi/protocol/packets/s2c/ChunkDataPacket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@ public void encode(ByteBuf buf, Direction direction, ProtocolVersion version) {
buf.writeBytes(data);
if (version.compareTo(ProtocolVersion.MINECRAFT_1_9_4) >= 0) {
List<VirtualBlockEntity.Entry> blockEntityEntries = this.chunk.getBlockEntityEntries();
ProtocolUtils.writeVarInt(buf, blockEntityEntries.size());
for (VirtualBlockEntity.Entry blockEntityEntry : blockEntityEntries) {
// Filter block entities to only include those supported on this version
List<VirtualBlockEntity.Entry> supportedEntries = blockEntityEntries.stream()
.filter(entry -> entry.getBlockEntity().isSupportedOn(version))
.toList();
ProtocolUtils.writeVarInt(buf, supportedEntries.size());
for (VirtualBlockEntity.Entry blockEntityEntry : supportedEntries) {
CompoundBinaryTag blockEntityNbt = blockEntityEntry.getNbt();
if (version.compareTo(ProtocolVersion.MINECRAFT_1_18) >= 0) {
buf.writeByte(((blockEntityEntry.getPosX() & 15) << 4) | (blockEntityEntry.getPosZ() & 15));
Expand Down