Closed
Conversation
rustyrussell
approved these changes
Jun 25, 2020
cdecker
approved these changes
Jun 25, 2020
Member
cdecker
left a comment
cdecker
left a comment
There was a problem hiding this comment.
Seems to also have the same check-source issue from #3783, so might require a quick rebase that'll invalidate my ack, but here it goes :-)
ACK 39de31c
Blocked by ElementsProject/libwally-core#201
we're moving over to elements!
Collaborator
Author
|
Rebased on top of master, now that #3783 has been merged. |
Member
|
Checked against the range-diff ACK 9f1de70 |
Collaborator
Author
|
Superceded by #3827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on ElementsProject/libwally-core#201
Builds on #3783. See just the last commit, 39de31c