Skip to content

Conversation

@siyeongjang
Copy link
Contributor

Theme: Secret Garden KR

This PR re-submits a pastel theme inspired by the tranquil beauty of Changgyeonggung Palace’s Secret Garden.

Included Files:

  • theme.yaml
  • logo.png
  • background_320x480.png
  • background_480x272.png
  • screenshot1.png
  • screenshot2.png
  • screenshot3.png
  • Additional optional screenshots

The theme has been tested on a TX16S MKII running EdgeTX 2.10.6.

I would appreciate your review and feedback. Thank you!

@siyeongjang
Copy link
Contributor Author

테마: Secret Garden KR

이 Pull Request는 창경궁 비원의 고요한 아름다움에서 영감을 받아 디자인된 파스텔 테마 Secret Garden KR을 제출하는 것입니다.
This PR re-submits a pastel theme inspired by the tranquil beauty of Changgyeonggung Palace’s Secret Garden.

포함된 파일:

  • theme.yaml
  • logo.png
  • background_320x480.png
  • background_480x272.png
  • screenshot1.png
  • screenshot2.png
  • screenshot3.png

해당 테마는 EdgeTX 2.10.6이 설치된 Radiomaster TX16S MKII 장비에서 테스트를 완료하였습니다.
The theme has been tested on a TX16S MKII running EdgeTX 2.10.6.

검토 및 반영을 부탁드립니다. 감사합니다.

@pfeerick
Copy link
Member

Theme generally looks good. Wallpaper is nice, but "busy" which is to be expected.

Since you have the source graphic for the wallpaper, could you also add the following sizes please?

  • background_320x240.png
  • background_480x320.png

Also. a trailing newline for THEMES/Secret_Garden_KR/theme.yml, which will get rid of this complaint from git / GitHub:
image

@siyeongjang
Copy link
Contributor Author

모든 피드백을 반영하여 수정 완료했습니다. 확인 부탁드립니다! 🙇‍♂️
All requested changes have been applied. Thank you!

@siyeongjang
Copy link
Contributor Author

I gave the screenshots a little upgrade and just pushed the update 🙂
Let me know if anything else needs tweaking. Thanks!

@pfeerick
Copy link
Member

pfeerick commented Apr 23, 2025

Can you add the following background images/sizes also please? They are optional, but better to add them now. Then it should be right to merge.

  • background_320x240.png
  • background_480x320.png

@siyeongjang
Copy link
Contributor Author

Added the optional background_320x240.png and background_480x320.png as requested.
Let me know if there's anything else — thanks again for the feedback! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants