Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

Conversation

@er1robyn
Copy link

@er1robyn er1robyn commented Jan 2, 2014

No description provided.

@basiliscus
Copy link

Thank you for the contribution. Unfortunately, there are some issues which prevent me from submitting the patch:

  1. The result type (Boolean) does not match the structure described at http://apidocs.mailchimp.com/api/rtfm/campaignstats.func.php . A new class (inherited from MailChimpObject) should be created to reflect the method return.
  2. To follow the naming convention, the class name should be CampaignStatsMethod instead of CampaignReport.

I'll gladly submit the patch once the issues are eliminated and the method outcome is tested.

@er1robyn
Copy link
Author

er1robyn commented Jan 4, 2014

No Issues Sir basiliscus,I made the return method and after testing I will again send you the Pull request.
Thanks for your reply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants