AR-469 Add Redis Client to Authentication Flow #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add functions for inventory tasks
remove log
src/auth/redisClient.ts
Outdated
|
|
||
| const hash = (text: any) => | ||
| crypto.createHash("sha256").update(text).digest("hex"); | ||
| const defaultKeyWord = "12345"; |
There was a problem hiding this comment.
Let's force the ENV to exist. We don't want to accidentally forget it and use 12345 as the key.
| hashedRefreshToken, | ||
| encryptedAccessToken, | ||
| "EX", | ||
| 2 * (HOUR_IN_SECONDS - 120) //set expiry to be after 1 hour 58 minutes |
There was a problem hiding this comment.
I think this ends up being 1 hour 56 minutes, which is fine, but might want to update it.
2 * (3600 - 120) = 7200 - 240 = 6960 => 116 minutes
patrickbrennan-ecomshft
approved these changes
Dec 16, 2021
patrickbrennan-ecomshft
left a comment
patrickbrennan-ecomshft
left a comment
There was a problem hiding this comment.
Just have the removal of the default key
Add fuctions for inventory tasks
add option to get request headers
updated name of branch in github actions
…Ecomshft/ebay-api into feat/AddHeaderToGetOfferRequest * 'feat/AddHeaderToGetOfferRequest' of https://github.com/Ecomshft/ebay-api: Update npm-publish.yml
changed branch to default branch
…Ecomshft/ebay-api into feat/AddHeaderToGetOfferRequest * 'feat/AddHeaderToGetOfferRequest' of https://github.com/Ecomshft/ebay-api: Update npm-publish.yml # Conflicts: # .github/workflows/npm-publish.yml
Add header to get offer request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.