Skip to content

Fix intermittent errors for Swaps #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lydiagarms merged 5 commits into from
Dec 23, 2025
Merged

Fix intermittent errors for Swaps #471

lydiagarms merged 5 commits into from
Dec 23, 2025

Conversation

@lydiagarms
Copy link
Collaborator

@lydiagarms lydiagarms commented Dec 19, 2025 •
edited
Loading

This PR fixes two issues that was causing the Swap.zol contract to fail in the zapp test intermittently:

  • Public keys in Starlight are compressed to allow for my efficient storage. Rejection sampling ensures the y coordinate is always smaller than 253 bits. For the shared public key however the y coordinate was just shortened to less than 253, even if longer than that length.
  • In the zapp-tests for Swap.zol the backupDataRetriever API was being called immediately after completeSwap finished. However the backup event listener also started at this point, leading to race conditions. To fix this the backupDataRetriever now waits for the event listener to finish before beginning.

@lydiagarms lydiagarms force-pushed the lyd/sharedPKeyFix branch 3 times, most recently from f2b647b to 6a663d3 Compare December 22, 2025 18:19
@lydiagarms lydiagarms changed the title fix(orchestration): badly generated public shared keys Fix intermittent errors for Swaps Dec 23, 2025
@lydiagarms lydiagarms requested a review from SwatiEY December 23, 2025 11:13
SwatiEY
SwatiEY previously approved these changes Dec 23, 2025
View reviewed changes
@lydiagarms lydiagarms requested a review from kKahina December 23, 2025 11:38
kKahina
kKahina requested changes Dec 23, 2025
View reviewed changes
kKahina
kKahina approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@kKahina kKahina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@lydiagarms lydiagarms merged commit afdd6b9 into master Dec 23, 2025
2 checks passed
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

🎉 This PR is included in version 1.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwatiEY SwatiEY SwatiEY approved these changes

@kKahina kKahina kKahina approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lydiagarms @SwatiEY @kKahina