[STALE] Replace mui comps with lumen-labs comps #10
Conversation
|
✔️ Deploy Preview for flood-maps ready! 🔨 Explore the source changes: 88eee05 🔍 Inspect the deploy log: https://app.netlify.com/sites/flood-maps/deploys/61c357b62fc45000082dad90 😎 Browse the preview: https://deploy-preview-10--flood-maps.netlify.app/ |
src/controls.js
Outdated
| const [showFlodd, setShowFlood] = useState(true) | ||
| const [showFlood, setShowFlood] = useState(true) | ||
|
|
||
| const locationData = useMemo(() => [ |
There was a problem hiding this comment.
- I think a regular variable assignment (even outside of the component) would do fine here, because it's derived from a constant. Additionally, there should be a lint error that says something like "
useMemo does nothing when used with an empty dependency array".
| data={locationData} | ||
| size='lg' | ||
| setSelectedOption={{ title: location }} | ||
| endIcon={<Icons.ArrowDown size='md'/>} |
There was a problem hiding this comment.
ok, will wait for a release with this
| setShowBuildings(!showBuildings) | ||
| }} | ||
| label='Show Buildings' | ||
| color='warning' |
There was a problem hiding this comment.
design team might disagree with this, not exactly a huge issue though lol :D
There was a problem hiding this comment.
Yeah, I had no choice but to use the 'warning' choice to have a different colour, the only colour available to match the yellow I used on the map for buildings. I don't think using this in a switch would imply it also carries the semantic message with it. The semantics apply for alerts or buttons.
.netlify/.npmrc
Outdated
| @@ -0,0 +1,3 @@ | |||
| @eqworks:registry=https://npm.pkg.github.com/ | |||
There was a problem hiding this comment.
pretty sure we don't need this file because we're not accessing any private scoped packages (lumen-labs is public). Could be wrong though.
There was a problem hiding this comment.
Well, netlify deployment failed without this. I will try again. But you are right, it should have worked without it.
There was a problem hiding this comment.
Funny thing, now it worked without, hmmm....maybe I didn't read the error correctly in netlify.
geoerika
changed the title
Changes:
New look with lumen-labs comps:
