-
Notifications
You must be signed in to change notification settings - Fork 42
[Buffers] Synchronizing cyle enumeration #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ziadomalik
wants to merge
51
commits into
main
Choose a base branch
from
feat/ziad/synchronizing-cycles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also it's more modular now, take the logic out of the constructor, and a data flow graph describes a single thing, not an array of things
Collaborator
Author
|
Btw I have no idea what this |
Jiahui17
reviewed
Jan 5, 2026
Member
Jiahui17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some
include/dynamatic/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.h
Outdated
Show resolved
Hide resolved
include/dynamatic/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.h
Show resolved
Hide resolved
lib/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.cpp
Outdated
Show resolved
Hide resolved
lib/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.cpp
Outdated
Show resolved
Hide resolved
include/dynamatic/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.h
Outdated
Show resolved
Hide resolved
include/dynamatic/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.h
Show resolved
Hide resolved
lib/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.cpp
Outdated
Show resolved
Hide resolved
lib/Transforms/BufferPlacement/LatencyAndOccupancyBalancingSupport.cpp
Outdated
Show resolved
Hide resolved
Member
|
Could you remove the aig from the commit? |
ac3944e to
75a54b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also related PR for Reconvergent paths enumeration.
This feature enumerates synchronizing cycles, as they are defined in Xu, Josipović, FPGA'24, Section 4:
We start out by computing all the strongly-connected-components of the CFC using Kosaraju's algorithm, then we find all the cycles in the CFC using Boost's
tiernan_all_cyclesfunction. Using both of our findings, we can enumerate each pair of cycles, check them against above criteria and reconstruct a path between the pair and the common join if they do match.