Docker - with Ubuntu 16.04 #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Aug 20, 2019
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
I could build and successfully use the docker container by following the instructions in the README.md. I left a minor comment about some paths mentioned in that file, though.
I wonder whether it makes sense to move to or duplicate in README.md the test installation instructions that are in INSTALL.md. Another option is point the user to those instructions from the README.md. They're useful, but they're not immediately discoverable from the README.md if the user used the Docker container.
It also "cleans" the travis script by externalising some of the installation steps as scripts under `.ci`.
So the only need for sudo is to run `make install`
When building petsc it may download the dependencies on a place that's not being cached properly. Hopefully, running make will download them again
Thanks @giordano for your review
Removes the source and building folders for peits and zoltan
Make tests executable scripts
Start bash at login instead of zsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a docker container 🐋 for the old version running on 16.04 (now the same than Travis!).
Here we've also updated the readme and Travis to be homogenous with the docker. The installation instructions have been brought inside the repository to keep it in sync with what's currently there (and not pointed to the wiki as that becomes misleading with different versions).