Added char limit to connections in database table and form#7
Open
maalts wants to merge 1 commit intoEDesignLabs:masterfrom
Open
Added char limit to connections in database table and form#7maalts wants to merge 1 commit intoEDesignLabs:masterfrom
maalts wants to merge 1 commit intoEDesignLabs:masterfrom
Conversation
this section of code was making an error when the connection was added so i commented it out for now to get the add connection page to submit successfully. i worked on issue number 6 : Add character limit to connections here are the changes i made: 1. database table topic_photos: changed description column type from text to varchar(250) 2. add-photo.ctp file: added “limit: 250 characters” to label variable on line 50 suggestion: fix WideImage function and add validation function to show when 250 character limit is reached on the add connections page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 139 in file TopicPhoto.php
this section of code was making an error when the connection was added so i commented it out for now to get the add connection page to submit successfully.
i worked on issue number 6 : Add character limit to connections
here are the changes i made:
suggestion: fix WideImage function and add validation function to show when 250 character limit is reached on the add connections page.