-
Notifications
You must be signed in to change notification settings - Fork 3
Sponsors and Officer Update #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…acher project to completed
|
Visit the preview URL for this PR (updated for commit 0b266e5): https://eclairrobotics--pr24-manas-sponsors-updat-46j8mrsv.web.app (expires Sun, 19 Jan 2025 20:55:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 150807af4c601ea757f7d0a4dd845c67c6fe4369 |
vishalkantharaju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks solid, thank you for the good work!! Just had a couple of small comments
src/styles/sponsors.css
Outdated
| .currentSponsorCard:hover { | ||
| transform: scale(1.05); | ||
| box-shadow: 0 2em 2em rgba(0,0,0, 0.2); | ||
| cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the cards aren't currently clickable, thoughts on taking this out for now? Might lead to confusion with users
|
|
||
| <div style = {{height:"5rem"}}></div> | ||
| {/* <div style={{display:'flex', justifyContent:'center', alignContent:'center'}}> */} | ||
| <div style={{display:'flex', justifyContent:'center', alignContent:'center', width:'100%'}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the box stating "We are always trying to provide our members with the most cutting-edge robotics hardware available and would greatly appreciate any potential sponsorships. If you are interested in sponsoring UT ECLAIR, please contact us at the email below and we can send you our sponsor packet!", thoughts on making it a bit less clear? The dots in the background seem like they could make this harder to read
| email='sahanagana@utexas.edu' topAlignImage={false}/> | ||
| name='Cameron Cox' | ||
| position='Corporate Director' | ||
| img={cameronImg} bio="Hey y'all, I'm Cameron. I'm a computer Science Major with a passion for robotics and in my freetime I play D&D, piano and cook a lot." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| return ( | ||
| <div className='currentSponsorRow'> | ||
| <CurrentSponsorCard img={serviceNow} color='rgb(30, 59, 61)'/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is on me but can we make a colors resource file in one of the future pushes

Sponsors page no longer shows our old corporate package. Instead it has our 3 sponsors on it on square cards. This same row is present at the bottom of our homepage.

I added all of 2024 officers as well. I made the card information more flexible in case an officer doesn't have linked in or an email. Email refs are still broken, and I'm not sure why. They were broken on the original website and I thought the links were just wrong but they seem to be correct.