-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] Meal 구분자 " + " 에서 ", "로 변경 #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @HI-JIN2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 Pull Request는 사용자 인터페이스의 가독성을 향상시키는 데 중점을 둡니다. Meal 항목을 표시할 때 사용되는 구분자를 시각적으로 더 명확한 ", "로 변경하여, 사용자가 메뉴 내용을 더 쉽게 이해하고 빠르게 파악할 수 있도록 합니다. 이는 전반적인 사용자 경험을 개선하는 데 기여합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Meal 구분자를 +에서 ,로 변경하여 가독성을 개선하는 좋은 변경입니다. 더불어 코드의 유지보수성을 높이고 null 값 처리 방식을 개선하기 위해, 구분자를 상수로 추출하고 mapNotNull을 사용하는 것을 제안합니다.
app/src/main/java/com/eatssu/android/data/remote/dto/response/MealResponse.kt
Outdated
Show resolved
Hide resolved
PeraSite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Summary
보다 나은 가시성을 위해 Meal의 구분자를 " + " 에서 ", "로 변경합니다
Describe your changes
Issue