Skip to content

Conversation

@HI-JIN2
Copy link
Member

@HI-JIN2 HI-JIN2 commented Dec 21, 2025

Summary

화면 아이디

스크린샷 2025-12-29 오후 12 30 47
  • 리뷰v2 보기 REV_001000_V1
  • 리뷰v2 쓰기. REV_001001_V1
  • 리뷰v2 수정. REV_003000_V1

이벤트 수집

스크린샷 2025-12-29 오후 12 30 30
  • 리뷰v2작성 시작 write_review_v2
  • 리뷰v2작성 완료 complete_review_v2

Issue

To reviewers

제가 여러번 체크하긴했는데, screen id나 event 명 크로스체크 해주시면 감사하겠습니다!! 🙇‍♀️

@HI-JIN2 HI-JIN2 self-assigned this Dec 21, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @HI-JIN2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on integrating robust event logging into the 'review v2' feature set. The primary goal is to gain deeper insights into user behavior within the review flow, from viewing review lists to writing and modifying reviews. By tracking screen views and detailed submission metrics, the team can better understand feature engagement and optimize the user experience.

Highlights

  • Event Logging Implementation: Introduced comprehensive event logging across various review-related screens (list, modify, write) to track user interactions and screen views.
  • Screen ID Refinement: The ScreenId enum has been updated and clarified, removing outdated V1 entries and adding more specific V2 and V3 identifiers for review, write, modify, and photo-related screens.
  • Detailed Review Completion Logging: Enhanced the review submission process to log detailed information upon completion, including the user's rating, the number of liked menus, and whether a photo was attached.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 리뷰 v2 기능에 대한 로깅 이벤트를 추가하는 것을 목표로 하고 있습니다. 화면 조회 및 액션에 대한 로깅이 추가된 점이 좋습니다. 다만, 중복된 화면 ID와 v1/v2 이벤트 로깅이 혼용된 부분이 발견되어 수정이 필요해 보입니다. 자세한 내용은 아래 리뷰 코멘트를 참고해주세요.

@HI-JIN2 HI-JIN2 marked this pull request as ready for review December 29, 2025 04:58
Copy link
Member

@PeraSite PeraSite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 리뷰 처리하는 코드에서도 V2가 아니라 디폴트가 V2가 된 만큼 EventLogger에서도 v1 함수를 없애고 v2를 디폴트로 해도 될 것 같아요!

고유하게 남아있어야 할 화면 ID 등 enum은 유지하구요!

@HI-JIN2
Copy link
Member Author

HI-JIN2 commented Dec 30, 2025

고생하셨습니다! 리뷰 처리하는 코드에서도 V2가 아니라 디폴트가 V2가 된 만큼 EventLogger에서도 v1 함수를 없애고 v2를 디폴트로 해도 될 것 같아요!
고유하게 남아있어야 할 화면 ID 등 enum은 유지하구요!

@PeraSite 반영했슴당~ 613237e

@PeraSite
Copy link
Member

고생하셨습니다! 리뷰 처리하는 코드에서도 V2가 아니라 디폴트가 V2가 된 만큼 EventLogger에서도 v1 함수를 없애고 v2를 디폴트로 해도 될 것 같아요!

고유하게 남아있어야 할 화면 ID 등 enum은 유지하구요!

@PeraSite 반영했슴당~ 613237e

💯💯💯💯

@HI-JIN2 HI-JIN2 merged commit 047c23e into develop Dec 30, 2025
1 check passed
@HI-JIN2 HI-JIN2 deleted the feat/review-v2-logevent branch December 30, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

리뷰 v2 로깅

3 participants