-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] review v2 logevent #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @HI-JIN2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on integrating robust event logging into the 'review v2' feature set. The primary goal is to gain deeper insights into user behavior within the review flow, from viewing review lists to writing and modifying reviews. By tracking screen views and detailed submission metrics, the team can better understand feature engagement and optimize the user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 PR은 리뷰 v2 기능에 대한 로깅 이벤트를 추가하는 것을 목표로 하고 있습니다. 화면 조회 및 액션에 대한 로깅이 추가된 점이 좋습니다. 다만, 중복된 화면 ID와 v1/v2 이벤트 로깅이 혼용된 부분이 발견되어 수정이 필요해 보입니다. 자세한 내용은 아래 리뷰 코멘트를 참고해주세요.
app/src/main/java/com/eatssu/android/presentation/cafeteria/review/write/WriteReviewScreen.kt
Outdated
Show resolved
Hide resolved
PeraSite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 리뷰 처리하는 코드에서도 V2가 아니라 디폴트가 V2가 된 만큼 EventLogger에서도 v1 함수를 없애고 v2를 디폴트로 해도 될 것 같아요!
고유하게 남아있어야 할 화면 ID 등 enum은 유지하구요!
Summary
화면 아이디
이벤트 수집
Issue
To reviewers
제가 여러번 체크하긴했는데, screen id나 event 명 크로스체크 해주시면 감사하겠습니다!! 🙇♀️