fix: search through all translations of words#28
Conversation
|
Thank you for your contribution. I'll test this PR out when I finally be with a PC, in 1 day approximately. |
Dzheremi2
left a comment
There was a problem hiding this comment.
Looks good to me!
Also you've mentioned an accent insensitive search in #29, this is a nice idea and as you already have the code done, you can add that to this PR. But I think that this accent insensitive search should be an optinal feature (add a setting for it) for such cases when user needs to destinguish accented words from non-accented ones.
|
Hi. Thanks. I'll get that code into here. I like the idea of having it as an option. I'll need to look into how to do that. I'll get some time today or tomorrow evening. |
|
Hi. This should be ready for review. I'm not sure about the string that should appear in the settings page. Let me know if this needs changes. |
Hi,
Thanks for this amazing application. Noticed that the search bar only searches for the first translation of each word.
This PR:
I'm not well versed with python, so I couldn't think of a way to do this without using for and if.