feat: created gilpinflowssystem and demo #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new system class in src/dynadojo/systems for all of Gilpin's continuous systems (imported from dysts.flows). Added a demo in demos/systems to test those systems.
- Identify principal components that cover up to 90% variance - Use the remaining principal components (if j = d, then choose j = d-1) for OOD generation
mkanwal
requested changes
Jul 26, 2024
carynbear
requested changes
Jul 26, 2024
Collaborator
There was a problem hiding this comment.
Can you add your system to tests/test_deterministic.py all you need to do is import and add to the systems list. Then run the tests (see contributing.md) to make sure it passes.
Also fix any comments from @mkanwal and me?
* changed all params.json and params_file to config.json and config_file * changed all params.json and params_file to config.json and config_file. Made experiments config file and ran experiment. All works * changed last thing from save_params -> save_config --------- Co-authored-by: Caryn Tran <caryn.tran@berkeley.edu>
Resolves DynaDojo#67 Co-authored-by: lmclane23 <101528096+lmclane23@users.noreply.github.com>
…nditions Changed gilpin_flows demo to plot OOD initial points and also to test OOD points generation for all systems
added GilpinFlowsSystem to test_deterministic file added dysts as optional gilpin system dependency in pyproject.toml added comments to gilpin_flows.py added class method to search for all available gilpin systems
mkanwal
reviewed
Aug 1, 2024
mkanwal
reviewed
Aug 1, 2024
mkanwal
reviewed
Aug 1, 2024
also adjusted GIlpinFlowsSystem parameters to take on a default value
Fixes order of parameters in gilpin flows demo. Adds warning messages for wrong inputted dimensions. Adds function return type for make_data.
carynbear
approved these changes
Aug 6, 2024
generate initial conditions along the sample trajectory. Perturb points by an amount proportional to the mean and variance of the sample trajectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new system class in src/dynadojo/systems for all of Gilpin's continuous systems (imported from dysts.flows).
Added a demo in demos/systems to test those systems.