Make the enabled() function required

[thyseus]

the default behavior of enabling the plugin everywhere is dangerous, one may accidentally push the code to production.

[thyseus]

alternatively i thought about = false so the buttons would simply "disappear" instead of throwing an exception on existing installations ?

[bramr94]

That sounds like a good solution @thyseus

[thyseus]

So should i add the = false ? Downside is: having enabled() and then nothing happens, because, in fact, its disabled, is confusing. Both solutions have their downsides :)

[thyseus]

Last idea: we can rename it to enabledWhen() and make the parameter required, then its obvious what the method does ?

Would be an even bigger breaking change then, though.

[bramr94]

I think for now the best solution is:

    public function enabled(Closure | bool $value = false): static

When we have a new major version release, we can remove the default value.