Conversation
Update USGS Loader to run fetch sub daily values when the fixed timestamp is not provided
There was a problem hiding this comment.
Thanks Kunal!!
It looks like this removes the option for daily records? Can we make that optional? If there is a flag for daily/sub-daily, or if an hour is not provided, it simply does daily?
also, let's make the default for hourly only one single hour, if possible. better to make the default less, so it takes less time to run, and if the user want's more data, then they should ask for it.
src/loaders/usgs_loader.py
Outdated
|
|
||
| Args: | ||
| year, month, day: Target date | ||
| hour, minute: Optional - if provided, returns data for that specific |
There was a problem hiding this comment.
Somehow include an option to load the daily values?
There was a problem hiding this comment.
also, chose a default hour and minute for the sub-daily options, so the user doesn't accidentally ask for more data than they actually want. let's think of this as a tool for single, instantaneous, results. if user wants to get more data, then they should do the bulk download.
There was a problem hiding this comment.
Hi Dr. Frame, thanks for the review! I've pushed the updated changes addressing all your comments:
-
Daily values restored as default: get_streamflow(year, month, day) now fetches daily mean discharge via nwis.get_record(service='dv') by default, no hour/minute needed.
-
Sub-daily defaults to single timestamp get_streamflow(year, month, day, hour, minute) fetches one 15-minute instantaneous value get_streamflow(year, month, day, hour) fetches the 4 timestamps within that hour.
…d single Keep the Daily streamflow value as default and adding option to fetch hourly and single IV value
3 participants
Update USGS Loader to fetch sub-daily values when the fixed timestamp is not provided.