Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
5b3992c
refactor: Remove 79 unused imports identified by Periphery
DrunkOnJava Jul 29, 2025
38844c3
refactor: Remove 164 unused private variables
DrunkOnJava Jul 29, 2025
94dc683
docs: Add Periphery cleanup summary and helper scripts
DrunkOnJava Jul 29, 2025
7b8fcfb
refactor: Remove 5 critical unused module imports
DrunkOnJava Jul 29, 2025
f6eded5
feat: Implement Periphery baseline tracking system
DrunkOnJava Jul 29, 2025
fe6ec91
refactor: Remove 3 unused private encryption methods from DefaultExpo…
DrunkOnJava Jul 29, 2025
c57e4d6
refactor: Remove unused mock classes and structs from MissingComponents
DrunkOnJava Jul 29, 2025
89dc97a
feat: Wire up InsurancePolicyRepository to functioning codebase
DrunkOnJava Jul 29, 2025
fc88b85
feat: Add GitHub Actions CI/CD workflows for PR validation and automa…
DrunkOnJava Jul 30, 2025
ef746f8
fix: Downgrade accessibility SwiftLint rules from error to warning fo…
DrunkOnJava Jul 30, 2025
90ff90a
fix: Remove problematic path modification in PR validation workflow
DrunkOnJava Jul 30, 2025
6fd99da
fix: Update CI workflows to use macOS-14 and add proper permissions
DrunkOnJava Jul 30, 2025
626efed
fix: Remove UIScreenshots scheme references from test workflow
DrunkOnJava Jul 30, 2025
cff7f1a
fix: Completely remove UIScreenshots target from project.yml
DrunkOnJava Jul 30, 2025
66daad5
fix: Update localization helper to work without .strings files
DrunkOnJava Jul 30, 2025
58494d3
fix: Remove deleted Localizable.strings file from git tracking
DrunkOnJava Jul 30, 2025
5912f35
fix: Simplify PR validation build process
DrunkOnJava Jul 30, 2025
4ea6360
docs: Update maintenance report with completed CI/CD implementation
DrunkOnJava Jul 30, 2025
5d9daf2
Merge remote-tracking branch 'origin/main' into cleanup/periphery-ana…
DrunkOnJava Jul 30, 2025
9f9ac0e
fix: Update module imports and SettingsStorage protocol
DrunkOnJava Jul 30, 2025
39a96fe
fix: Fix remaining compilation errors in FoundationCore and module im…
DrunkOnJava Jul 30, 2025
a928180
fix: Fix remaining compilation errors for CI validation
DrunkOnJava Jul 30, 2025
230ffa2
fix: Fix weak self capture in ErrorContext.swift Task closure
DrunkOnJava Jul 30, 2025
ee383f7
fix: Fix Infrastructure-Monitoring Logger.swift compilation errors
DrunkOnJava Jul 30, 2025
6316103
fix: Add missing telemetryData property to ServiceError conforming enums
DrunkOnJava Jul 30, 2025
17171c1
fix: Add macOS platform support to Foundation packages for CI compati…
DrunkOnJava Jul 30, 2025
49aef93
fix: Add missing telemetryData parameters and macOS platform support
DrunkOnJava Jul 30, 2025
be8e6cc
fix: Remove redundant availability check and add macOS platform to In…
DrunkOnJava Jul 30, 2025
e5cb8ee
trigger: Force CI re-run after fixes
DrunkOnJava Jul 31, 2025
fe9538b
fix: Add telemetryData property to PhotoStorageError for ServiceError…
DrunkOnJava Jul 31, 2025
713df87
fix: Add telemetryData to NetworkError and fix import formatting
DrunkOnJava Jul 31, 2025
dae8244
fix: Correct import statements to use proper module names
DrunkOnJava Jul 31, 2025
7bffb5a
fix: Complete import statement corrections
DrunkOnJava Jul 31, 2025
9ffdf58
refactor: Clean up feature flags to only keep essential ones
DrunkOnJava Jul 31, 2025
46abfd1
fix: Correct hyphenated module imports to camelCase
DrunkOnJava Jul 31, 2025
56619f9
Fix ErrorRecoveryEngine iOS availability annotations
DrunkOnJava Jul 31, 2025
2dce156
feat: Migrate Services-Authentication to Swift 6 compatibility
DrunkOnJava Jul 31, 2025
2de0c31
feat: Migrate Services-Export module to Swift 6 compatibility
DrunkOnJava Jul 31, 2025
95353c6
feat: Update Infrastructure-Storage module to Swift 6 compatibility
DrunkOnJava Jul 31, 2025
9458115
feat: Update Infrastructure-Security module for Swift 6 compatibility
DrunkOnJava Jul 31, 2025
8ec853c
feat: Complete Infrastructure-Storage Swift 6 migration
DrunkOnJava Jul 31, 2025
5f51c68
feat: Complete Infrastructure-Monitoring Swift 6 migration
DrunkOnJava Jul 31, 2025
240c3c8
feat: Complete Infrastructure-Network Swift 6 migration
DrunkOnJava Jul 31, 2025
d0ad411
feat: Complete HomeInventoryCore Swift 6 migration
DrunkOnJava Jul 31, 2025
59ff39a
feat: Complete Services-Sync Swift 6 migration
DrunkOnJava Jul 31, 2025
72230eb
feat: Complete Services-Search Swift 6 migration
DrunkOnJava Jul 31, 2025
a42c4f4
feat: Complete Foundation-Models Swift 6 migration
DrunkOnJava Jul 31, 2025
691e840
feat: Complete Foundation-Resources Swift 6 migration
DrunkOnJava Jul 31, 2025
53bafa7
feat: Complete Services-External Swift 6 migration
DrunkOnJava Jul 31, 2025
c3375fd
feat: Complete Services-Business Swift 6 migration
DrunkOnJava Jul 31, 2025
5a2010f
feat: Complete Features-Analytics Swift 6 migration
DrunkOnJava Jul 31, 2025
393a667
feat: Complete Features-Inventory Swift 6 migration
DrunkOnJava Jul 31, 2025
8ce9d10
feat: Complete Features-Onboarding Swift 6 migration
DrunkOnJava Jul 31, 2025
d16e539
feat: Complete Features-Gmail Swift 6 migration
DrunkOnJava Jul 31, 2025
4b594d1
feat: Complete Features-Sync Swift 6 migration
DrunkOnJava Jul 31, 2025
d1d3d9e
feat: Complete Features-Settings Swift 6 migration
DrunkOnJava Jul 31, 2025
3715d56
feat: Complete Features-Locations Swift 6 migration
DrunkOnJava Jul 31, 2025
5dcbb15
feat: Complete Features-Scanner Swift 6 migration
DrunkOnJava Jul 31, 2025
1d85075
feat: Complete Features-Receipts Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
3254046
feat: Complete App-Widgets Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
f15b625
feat: Complete App-Main Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
e9365ad
feat: Complete Features-Premium Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
476d9d6
feat: Complete UI-Core Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
3f5c03b
feat: Complete UI-Components Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
2069190
feat: Complete UI-Styles Swift 6 migration - FINAL BATCH
DrunkOnJava Jul 31, 2025
393eafb
feat: Complete UI-Navigation Swift 6 migration - FINAL 3
DrunkOnJava Jul 31, 2025
abf4e88
feat: Complete App-Widget Swift 6 migration - FINAL 3
DrunkOnJava Jul 31, 2025
ac75316
feat: Complete Foundation-Core Swift 6 migration - FINAL 3
DrunkOnJava Jul 31, 2025
cc4f9c2
feat(insurance): Complete modular refactoring of InsuranceReportService
DrunkOnJava Jul 31, 2025
3809fb0
feat: Refactor FeaturesSync into modular architecture
DrunkOnJava Jul 31, 2025
1d203cd
feat: Add comprehensive refactoring prompts and Swift 6 compiler cras…
DrunkOnJava Jul 31, 2025
7367164
feat: Refactor CollaborativeListsView into modular architecture
DrunkOnJava Jul 31, 2025
4ad3790
feat: Refactor ServiceError into comprehensive error handling system
DrunkOnJava Jul 31, 2025
de5f528
feat: Complete CollaborativeListDetailView modular refactoring
DrunkOnJava Jul 31, 2025
294e9f6
feat: Major cleanup and modular refactoring
DrunkOnJava Jul 31, 2025
5f43d1c
feat: Configure single source of truth workflow
DrunkOnJava Jul 31, 2025
382425e
feat(claude): Add commit size enforcement workflow
DrunkOnJava Jul 31, 2025
7567edf
docs(claude): Add Claude commit rules documentation
DrunkOnJava Jul 31, 2025
a839f67
feat(claude): Add PR auto-merge and lifetime rules
DrunkOnJava Jul 31, 2025
76eb8b6
feat(claude): Update hooks and templates for incremental development
DrunkOnJava Jul 31, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .agents/coordination/build-monitor.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# ModularHomeInventory - Build Status Monitor
# Monitors build status across all agent worktrees
Expand Down
2 changes: 1 addition & 1 deletion .agents/coordination/git-monitor.sh
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# ModularHomeInventory - Git Activity Monitor
# Enhanced for iTerm2 with visual branch trees and color coding
Expand Down
2 changes: 1 addition & 1 deletion .agents/coordination/notification-hub.sh
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# ModularHomeInventory - Notification Hub
# iTerm2 badge and desktop notification integration
Expand Down
2 changes: 1 addition & 1 deletion .agents/hooks/agent1/environment.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Agent 1: DDD Domain Foundation - Environment Setup
# This script sets up the development environment for Agent 1
Expand Down
2 changes: 1 addition & 1 deletion .agents/hooks/agent1/status-update.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Agent 1: DDD Domain Foundation - Status Update Script
# This script updates the agent's status based on current progress
Expand Down
2 changes: 1 addition & 1 deletion .agents/setup-dependencies.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Install Python dependencies for agent coordination tools

Expand Down
2 changes: 1 addition & 1 deletion .claude/reports/generate-module-report-simple.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# ModularHomeInventory Module Analysis Report Generator
# Compatible with macOS default bash
Expand Down
13 changes: 12 additions & 1 deletion .claude/settings.local.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,18 @@
"mcp__filesystem__search_files",
"mcp__filesystem__edit_file",
"Bash(git reset:*)",
"Bash(periphery scan:*)"
"Bash(periphery scan:*)",
"Bash(jq:*)",
"Bash(./scripts/cleanup/remove-instance-methods-auto.sh:*)",
"Bash(./scripts/validate-module-dependencies.sh:*)",
"Bash(./scripts/build-parallel.sh:*)",
"Bash(--title \"Fix Missing Module Import Errors\" )",
"Bash(--body \"## Issue Description\nMultiple files are failing to compile due to missing module imports. The compiler cannot find the specified modules, preventing successful builds.\n\n## Affected Files and Missing Modules\n- \\`App-Main/Sources/AppMain/AppContainer.swift\\` - Missing \\`ServicesSearch\\`\n- \\`Features-Analytics/Sources/FeaturesAnalytics/Views/AnalyticsHomeView.swift\\` - Missing \\`UIComponents\\`\n- \\`Features-Locations/Sources/FeaturesLocations/Views/LocationsHomeView.swift\\` - Missing \\`UIComponents\\`\n- \\`Features-Scanner/Sources/FeaturesScanner/FeaturesScanner.swift\\` - Missing \\`ServicesExternal\\`\n- \\`Services-Authentication/Sources/ServicesAuthentication/AuthenticationService.swift\\` - Missing \\`InfrastructureSecurity\\`\n- \\`Services-Business/Sources/Services-Business/Budget/BudgetService.swift\\` - Missing \\`InfrastructureStorage\\`\n- \\`Services-Search/Sources/ServicesSearch/SearchService.swift\\` - Missing \\`InfrastructureStorage\\`\n- \\`Features-Receipts/Sources/FeaturesReceipts/FeaturesReceipts.swift\\` - Missing \\`ServicesExternal\\`\n- \\`Features-Settings/Sources/FeaturesSettings/Extensions/MissingComponents.swift\\` - Missing \\`UIComponents\\`\n- \\`Features-Inventory/Sources/FeaturesInventory/ViewModels/ItemsListViewModel.swift\\` - Missing \\`ServicesSearch\\`\n- \\`UI-Core/Sources/UICore/ViewModels/BaseViewModel.swift\\` - Missing \\`InfrastructureNetwork\\`\n- \\`Infrastructure-Security/Sources/Infrastructure-Security/Authentication/CertificatePinning.swift\\` - Missing \\`InfrastructureStorage\\`\n- \\`Supporting Files/App.swift\\` - Missing \\`HomeInventoryApp\\`\n- Multiple \\`UIComponents\\` files - Missing \\`Foundation_Models\\` (should be \\`FoundationModels\\`)\n\n## Root Cause\nThe primary causes are:\n1. Missing module dependencies in \\`Package.swift\\` files\n2. Incorrect module naming (e.g., \\`Foundation_Models\\` vs \\`FoundationModels\\`)\n3. Package target configuration issues\n\n## Solution Plan\n1. Verify and update all \\`Package.swift\\` files to include missing dependencies\n2. Correct module naming inconsistencies\n3. Ensure proper product name mappings in target dependencies\n4. Validate Xcode project target dependencies\n\n## Priority\n**High** - These are foundational errors that prevent the entire project from building.\n\n## Acceptance Criteria\n- [ ] All \\`No such module\\` compilation errors are resolved\n- [ ] All Package.swift files have correct dependencies\n- [ ] Module naming is consistent throughout the project\n- [ ] Project builds successfully without import errors\")",
"Bash(./scripts/update-renamed-types.sh:*)",
"Bash(./scripts/audit-verify.sh:*)",
"Bash(for:*)",
"Bash(-exec swift -frontend -typecheck {})",
"Bash(git fetch:*)"
],
"deny": []
},
Expand Down
Binary file added .github/.DS_Store
Binary file not shown.
108 changes: 72 additions & 36 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,55 +3,91 @@
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# Default owners for everything in the repo
* @griffinradcliffe
* @DrunkOnJava

# iOS/Swift specific files
*.swift @griffinradcliffe
*.storyboard @griffinradcliffe
*.xib @griffinradcliffe
*.xcodeproj/ @griffinradcliffe
*.xcworkspace/ @griffinradcliffe

# Module ownership
/Modules/Core/ @griffinradcliffe
/Modules/Items/ @griffinradcliffe
/Modules/Locations/ @griffinradcliffe
/Modules/Premium/ @griffinradcliffe
/Modules/TestUtilities/ @griffinradcliffe
*.swift @DrunkOnJava
*.storyboard @DrunkOnJava
*.xib @DrunkOnJava
*.xcodeproj/ @DrunkOnJava
*.xcworkspace/ @DrunkOnJava

# Foundation Layer - Core domain logic
/Foundation-Core/ @DrunkOnJava
/Foundation-Models/ @DrunkOnJava
/Foundation-Resources/ @DrunkOnJava

# Infrastructure Layer - Technical capabilities
/Infrastructure-Network/ @DrunkOnJava
/Infrastructure-Storage/ @DrunkOnJava
/Infrastructure-Security/ @DrunkOnJava
/Infrastructure-Monitoring/ @DrunkOnJava

# Services Layer - Business services
/Services-Authentication/ @DrunkOnJava
/Services-Business/ @DrunkOnJava
/Services-External/ @DrunkOnJava
/Services-Search/ @DrunkOnJava
/Services-Sync/ @DrunkOnJava
/Services-Export/ @DrunkOnJava

# UI Layer - Presentation components
/UI-Core/ @DrunkOnJava
/UI-Components/ @DrunkOnJava
/UI-Styles/ @DrunkOnJava
/UI-Navigation/ @DrunkOnJava

# Features Layer - User-facing features
/Features-Inventory/ @DrunkOnJava
/Features-Scanner/ @DrunkOnJava
/Features-Settings/ @DrunkOnJava
/Features-Analytics/ @DrunkOnJava
/Features-Locations/ @DrunkOnJava
/Features-Sync/ @DrunkOnJava
/Features-Receipts/ @DrunkOnJava
/Features-Premium/ @DrunkOnJava
/Features-Onboarding/ @DrunkOnJava
/Features-Gmail/ @DrunkOnJava

# Configuration files
Package.swift @griffinradcliffe
Package.resolved @griffinradcliffe
Gemfile @griffinradcliffe
Gemfile.lock @griffinradcliffe
Makefile @griffinradcliffe
Package.swift @DrunkOnJava
Package.resolved @DrunkOnJava
Gemfile @DrunkOnJava
Gemfile.lock @DrunkOnJava
Makefile @DrunkOnJava

# CI/CD and automation
/.github/ @griffinradcliffe
/fastlane/ @griffinradcliffe
/scripts/ @griffinradcliffe
/.github/ @DrunkOnJava
/fastlane/ @DrunkOnJava
/scripts/ @DrunkOnJava

# Documentation
*.md @griffinradcliffe
/docs/ @griffinradcliffe
*.md @DrunkOnJava
/docs/ @DrunkOnJava

# Security-sensitive files (require extra attention)
*.plist @griffinradcliffe
*.entitlements @griffinradcliffe
/.env* @griffinradcliffe
/secrets/ @griffinradcliffe
*.plist @DrunkOnJava
*.entitlements @DrunkOnJava
/.env* @DrunkOnJava
/secrets/ @DrunkOnJava
*Security*.swift @DrunkOnJava
*Encryption*.swift @DrunkOnJava
*Keychain*.swift @DrunkOnJava

# Test files (can have relaxed review)
*Tests.swift @griffinradcliffe
*Test.swift @griffinradcliffe
/Tests/ @griffinradcliffe
*UITests.swift @griffinradcliffe
*Tests.swift @DrunkOnJava
*Test.swift @DrunkOnJava
/Tests/ @DrunkOnJava
*UITests.swift @DrunkOnJava
/HomeInventoryModularTests/ @DrunkOnJava
/HomeInventoryModularUITests/ @DrunkOnJava

# Dependencies (automated PRs need less strict review)
.github/dependabot.yml @griffinradcliffe
renovate.json @griffinradcliffe
.github/dependabot.yml @DrunkOnJava
renovate.json @DrunkOnJava

# Build and project files
project.yml @griffinradcliffe
.swiftlint.yml @griffinradcliffe
.swiftformat @griffinradcliffe
project.yml @DrunkOnJava
.swiftlint.yml @DrunkOnJava
.swiftformat @DrunkOnJava
*.xcconfig @DrunkOnJava
Loading
Loading