Fix unsigned Size type issues and migrate to C++20 standard#3
Merged
chenpeizhi merged 2 commits intoDrudgeCAS:masterfrom Nov 10, 2025
Merged
Fix unsigned Size type issues and migrate to C++20 standard#3chenpeizhi merged 2 commits intoDrudgeCAS:masterfrom
chenpeizhi merged 2 commits intoDrudgeCAS:masterfrom
Conversation
…o C++20 standard (#1) * Fix find_last() to return SIZE_MAX instead of -1 for unsigned Size type * Add explicit casts for builtin function returns and fix sign-conversion warnings * Migrate from GCC builtins to C++20 standard library bit operations --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the fbitset library by replacing GCC-specific compiler intrinsics with portable C++20 standard library bit manipulation functions from the <bit> header.
Key Changes:
- Replaced
__builtin_clz,__builtin_ctz, and__builtin_popcountintrinsics withstd::countl_zero,std::countr_zero, andstd::popcountrespectively - Changed
find_last()return value from-1tostd::numeric_limits<Size>::max()for consistency with unsigned type semantics - Updated build requirements to C++20 and CMake 3.12
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/fbitset.hpp | Replaced GCC intrinsics with C++20 <bit> header functions; updated find_last() return value and documentation |
| test/basic.cpp | Added explicit Size() casts in initializer list; updated test assertion for new find_last() return value |
| README.md | Updated documentation to reflect use of C++20 <bit> header instead of GCC intrinsics |
| CMakeLists.txt | Updated minimum CMake version to 3.12, C++ standard to 20, and added CMAKE_CXX_STANDARD_REQUIRED |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix find_last() to return SIZE_MAX instead of -1 for unsigned Size type
Add explicit casts for builtin function returns and fix sign-conversion warnings
Migrate from GCC builtins to C++20 standard library bit operations