fix(syscall): 修复一些系统调用 #1622

xboHodx · 2026-01-08T13:25:06Z

chmod_test 的 ChmodTest.FchmodatNotDir
open_test 的 OpenTest.OpenNoFollowSymlink
修复sysinfo_test并把sysinfo系统调用移到新的文件sys_sysinfo.rs中
mkdir_test 的 MkdirTest.FailsOnDirWithoutWritePerms
修改gvisor测试的white_list和block_list

fslongjin · 2026-01-08T13:50:29Z

bugbot run

kernel/src/filesystem/vfs/open.rs

fslongjin · 2026-01-09T02:53:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3284ad11b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kernel/src/filesystem/vfs/open.rs

feat(time): 增加系统启动时间和运行时间的计算 fix(process): 添加获取当前进程数量的函数

xboHodx · 2026-01-10T13:53:35Z

bugbot run

cursor · 2026-01-10T13:53:37Z

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

fslongjin · 2026-01-11T07:25:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52d659b36a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kernel/src/time/timekeeping.rs

fslongjin · 2026-01-11T12:24:26Z

kernel/src/syscall/sys_sysinfo.rs

+#[derive(Debug, Default, Copy, Clone)]
+#[repr(C)]
+pub struct SysInfo {
+    uptime: u64,
+    loads: [u64; 3],
+    totalram: u64,
+    freeram: u64,
+    sharedram: u64,
+    bufferram: u64,
+    totalswap: u64,
+    freeswap: u64,
+    procs: u16,
+    pad: u16,
+    totalhigh: u64,
+    freehigh: u64,
+    mem_unit: u32,


这个是给用户态的结构体，如果外面用不到，就不用pub。并且要以PosixSysInfo这样命名，以便跟内核其他系统调用的命名规则一致。

可是sysinfo不是posix标准的系统调用呀

可是sysinfo不是posix标准的系统调用呀

这里的Posix的意思指的是对齐Linux的面向用户态的结构体。避免内核态把他混淆使用。

fslongjin · 2026-01-11T12:24:47Z

kernel/src/syscall/sys_sysinfo.rs

+    sysinfo.freehigh = 0;
+    sysinfo.mem_unit = 1;
+
+    writer.copy_one_to_user(&sysinfo, 0)?;


要使用基于异常表保护的版本

UserBuffer 中有基于异常表保护拷贝实现的 write_one<T>() ，可以考虑使用这个。

好多用这个的

详情请看这个 Project: [Security] User Access 补完。

对应以下三个 issue需要完成：

# 1590 CORE-326

refactor: Using UserBuffer to obtain user-mode data in the general system calls #1593 CORE-328

feat: 实现 user_access::get_user() 用于基本类型、带异常的用户态变量拷贝 #1588 CORE-325

后面有空应该要集中重构。

kernel/src/process/mod.rs

fix(timekeeping): 优化时间初始化逻辑，移除不必要的调试信息

…scall_1

fslongjin · 2026-01-13T14:20:49Z

kernel/src/time/timekeeping.rs

这样设置不对8。墙上时间的更新我理解应该是update_walltime 的职责? 在update_walltime以外的地方，直接去改xtime的值我觉得应该是不合理的。因为时间子系统有自己的一套机制去更新这个。

我理解你这里的需求是计算系统自启动以来的时间？那直接Instant::now不就好了。在LATE的时间点，时间子系统都已经工作了。

fslongjin · 2026-01-13T14:22:04Z

kernel/src/syscall/sys_sysinfo.rs

+#[derive(Debug, Default, Copy, Clone)]
+#[repr(C)]
+pub struct SysInfo {
+    uptime: u64,
+    loads: [u64; 3],
+    totalram: u64,
+    freeram: u64,
+    sharedram: u64,
+    bufferram: u64,
+    totalswap: u64,
+    freeswap: u64,
+    procs: u16,
+    pad: u16,
+    totalhigh: u64,
+    freehigh: u64,
+    mem_unit: u32,


可是sysinfo不是posix标准的系统调用呀

这里的Posix的意思指的是对齐Linux的面向用户态的结构体。避免内核态把他混淆使用。

fslongjin · 2026-01-13T14:24:37Z

kernel/src/process/mod.rs

+    /// 获取当前 PID namespace 中的进程数量
+    pub fn ns_process_count() -> usize {
+        Self::current_pcb().active_pid_ns().pid_allocated()
+    }


这个函数就那个地方用到，我理解直接ProcessManager::current_pidns().pid_allocated()这样比较好。应当在pidns那边impl一个current_pidns()而不是这里这个ns_process_count()

…scall_1

fix(vfs): 添加路径为空和符号链接处理的错误检查

3284ad1

github-actions bot added Bug fix A bug is fixed in this pull request test Unitest/User space test labels Jan 8, 2026

cursor bot reviewed Jan 8, 2026

View reviewed changes

kernel/src/filesystem/vfs/open.rs Show resolved Hide resolved

xboHodx changed the title ~~fix(vfs): 添加路径为空和符号链接处理的错误检查~~ [TBD] fix(vfs): 添加路径为空和符号链接处理的错误检查 Jan 8, 2026

github-actions bot added the ambiguous The title of PR/issue doesn't match the format label Jan 8, 2026

xboHodx changed the title ~~[TBD] fix(vfs): 添加路径为空和符号链接处理的错误检查~~ [TBD] fix(syscall): 修复一些系统调用 Jan 8, 2026

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

kernel/src/filesystem/vfs/open.rs Outdated Show resolved Hide resolved

xboHodx added 4 commits January 9, 2026 12:54

fix(vfs): 修复do_sys_openat2函数中的符号链接处理逻辑

1a44323

feat(syscall): 添加sysinfo系统调用以获取系统信息

53764b7

feat(time): 增加系统启动时间和运行时间的计算 fix(process): 添加获取当前进程数量的函数

fix(vfs): 更新mkdir_at权限检查逻辑并移除无效测试用例

a0dc383

fix(timekeeping): 添加获取系统启动时间的函数并优化时间初始化逻辑

52d659b

xboHodx changed the title ~~[TBD] fix(syscall): 修复一些系统调用~~ fix(syscall): 修复一些系统调用 Jan 10, 2026

github-actions bot removed the ambiguous The title of PR/issue doesn't match the format label Jan 10, 2026

chatgpt-codex-connector bot reviewed Jan 11, 2026

View reviewed changes

kernel/src/time/timekeeping.rs Show resolved Hide resolved

fix(timekeeping): 修复timekeeper的xtime更新逻辑以正确处理纳秒

1850ae5

xboHodx changed the title ~~fix(syscall): 修复一些系统调用~~ [TBD] fix(syscall): 修复一些系统调用 Jan 11, 2026

github-actions bot added the ambiguous The title of PR/issue doesn't match the format label Jan 11, 2026

xboHodx changed the title ~~[TBD] fix(syscall): 修复一些系统调用~~ fix(syscall): 修复一些系统调用 Jan 11, 2026

github-actions bot removed the ambiguous The title of PR/issue doesn't match the format label Jan 11, 2026

fslongjin requested changes Jan 11, 2026

View reviewed changes

fslongjin mentioned this pull request Jan 11, 2026

fix(syscall): 修复 sysinfo 系统调用未填充关键字段的问题 #1630

Closed

xboHodx added 3 commits January 12, 2026 18:46

fix(syscall): 更新进程计数函数以支持当前 PID namespace

68ebd8f

fix(syscall): 修正获取进程计数的逻辑以适应当前 PID namespace

8550f1c

fix(timekeeping): 优化时间初始化逻辑，移除不必要的调试信息

fmt

981a4a6

xboHodx requested a review from fslongjin January 12, 2026 13:16

Merge branch 'master' of github.com:xboHodx/DragonOS into fix/some_sy…

3d1537c

…scall_1

fslongjin requested changes Jan 13, 2026

View reviewed changes

xboHodx added 6 commits January 14, 2026 14:06

refactor(syscall): 重命名 SysInfo 为 PosixSysInfo；添加获取当前 PID namespace 的方法

06b600c

refactor(timekeeping): 更新时间更新函数以修复死锁问题

c529215

fmt

fa0c7e2

fmt

2dbcba1

refactor(timekeeping): 移除不必要的引导时间设置和原子操作

f7d6f5c

Merge branch 'master' of github.com:xboHodx/DragonOS into fix/some_sy…

afd88c2

…scall_1

Uh oh!

fix(syscall): 修复一些系统调用 #1622

Are you sure you want to change the base?

fix(syscall): 修复一些系统调用 #1622

Uh oh!

Conversation

xboHodx commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fslongjin commented Jan 8, 2026

Uh oh!

Uh oh!

fslongjin commented Jan 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xboHodx commented Jan 10, 2026

Uh oh!

cursor bot commented Jan 10, 2026

Uh oh!

fslongjin commented Jan 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mistcoversmyeyes Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xboHodx commented Jan 8, 2026 •

edited

Loading

mistcoversmyeyes Jan 12, 2026 •

edited

Loading