Skip to content

Conversation

@lacostej
Copy link
Member

This could also make #13 obsolete. Let's merge this one first and see how circle reacts.

@lacostej lacostej requested a review from niezbop November 17, 2019 18:06
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what the master branch is, nor how CircleCI is supposed to run now

@lacostej
Copy link
Member Author

Not sure I understand what the master branch is, nor how CircleCI is supposed to run now

The master branch is the git master branch. It contains its own circleci configuration that is up to date with circleci requirements and contains [instructions to only build master](https://github.com/DragonBox/unities/blob/master/.circleci/config.yml#L52-L68].

Still I am seeing build failures (and notifications) on circleci every hour:

image

I am just trying to get rid of them. I suspect it is because the circleci v1 configuration in the gh-pages project is triggering the builds, overriding the master branch circleci configuration.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification

@lacostej lacostej merged commit c71ee2c into gh-pages Nov 18, 2019
@lacostej lacostej deleted the internal/remove_ghpages_branch_config_circleci branch November 18, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants