Open
Conversation
Collaborator
|
This change is breaking, meta macros need to be added to keep old behaviour, breaking changes will not be accepted |
Author
|
✅ Thanks, I’ll update the PR. |
Collaborator
|
This look good, but I need to test it, T0 is the base, all tools are offset form it. So I need to test to make sure that doesn't change. If I want to get the offset to T1, T0 still needs to run first so that T1 is the offset from T0. So I want to make sure no edge cases exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove code duplication and refactor the calibration for both single-tool and multi-tool setups into a single macro.
Ensure that the G-code offsets are saved under the correct tool names (e.g. [tool AVR1] instead of [tool T1]).