Conversation
|
This will break for those passing rawparams from print start cars can’t be changed like this, use logic from default print start and assume the same params are used. |
|
I don’t think I completely understand you. By calling it with {rawparams}, I meant that I followed the standard PRINT_START parameters as described in the StealthChanger documentation: https://github.com/DraftShift/StealthChanger/wiki/Slicers Of course, anyone can define or pass their own parameters to PRINT_START. As far as I can tell, the script is currently copied (not symlinked) during initial installation and isn’t called by default, since it’s part of the extra-macros. |
|
Correct keep the Param names the same |
|
If you are referring to this from a backwards compatibility perspective, the macro invocation has already changed regardless, as the tools to be primed must now be explicitly specified. As a fallback, I could consider defaulting to the preheated tools when no temperature values are provided for the individual tools? If you mean that I should follow the parameters from the PRINT_START documentation, that is what I have done. |
|
I’ll just fix it when o have time I’ll keep this open to sort it |
i'm not using preheating of the tools, but want to use prime-lines. Currently the macro depends on the tools being preheated.
The change accepts the params already used in PRINT_START to be passed to make the PRIME_LINES macro so it can be used without preheating.
In PRINT_START (and related macros) it can be now called with the rawparams:
PRIME_LINES {rawparams}