1.2.1-beta merge #15
Merged
1.2.1-beta merge #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to not utilizing `setState`. In addition to this, I gave `BooleanSetting` the ability to utilize a custom `onChanged` action. This custom action does by default not need to include `setState` nor a statement to update the value of the switch. Although if it is not needed to rebuild BooleanSetting after every value change (e.g. a larger rebuild occurs), then it can be turned of by setting `doSetState` to false. These changes make `LightBooleanSetting` redunant and has therefore been removed.
DrSolidDevil
added
the
Release merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
BooleanSettingnot updating in respose to user input. 02a152fOther Changes
LightBooleanSettingand replaced it withBooleanSettingwhich now has the ability to have customonChangedactions. 02a152f 17ebb98 f5f74f5