Configurable polling timeout and bugfix in watch.browser #58
Open
Messj1 wants to merge 2 commits intoDownload:masterfrom
Open
Configurable polling timeout and bugfix in watch.browser #58Messj1 wants to merge 2 commits intoDownload:masterfrom
Messj1 wants to merge 2 commits intoDownload:masterfrom
Conversation
[FEATURE] add bounds for poll_time to prevent unhandy config values [BUGFIX] add a Set to prevent starting multiple interval on already watched ulog instances [BUGFIX] add ulog after hook to update config immediately after loading all mods
Author
|
@Download Have you any idea why the I know, a pull request should only focus on one aspect, but the 3 Issues seems to be related on the same time synchronous problem. 🙈 |
Author
|
@Download This error seems to be a problem in the test case. The config of ulog contains The question now: Why are the configs I added some update: function(ulog) {
...
var changed = update(ulog.config, newCfg)
console.log("changed: ", changed);
...
},
...
after: function (logger) {
console.log("after [logger.level]: ", logger.level);
config.update(this);
console.log("after [logger.level]: ", logger.level);
}Console output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52, fixes #55 and fixes #56
[FEATURE] add poll_time config option to change interval timeout
[FEATURE] add bounds for poll_time to prevent unhandy config values
[BUGFIX] add a Set to prevent starting multiple interval on already watched ulog instances
[BUGFIX] add ulog after hook to update config immediately after loading all mods