Skip to content

Conversation

@rgharris
Copy link
Contributor

@rgharris rgharris commented May 27, 2025

This flag can be useful when using the CLI offline as network requests are not made when only using the fallback file. These changes apply to doppler run and doppler secrets download.

The approach taken here seems cleaner to me than the one originally taken in #478. Plus, the error messages here are clearer as they mention the specific flag (--fallback-only or --offline) that you utilized:

> doppler run --project=aaa --config=stg --scope=dev --offline --no-fallback --watch echo
Warning: --offline has no effect when the fallback file is disabled
Warning: --watch has no effect when used with --offline
Doppler Error: Conflict: unable to specify --no-fallback with --offline

> doppler run --project=aaa --config=stg --scope=dev --fallback-only --no-fallback --watch echo
Warning: --fallback-only has no effect when the fallback file is disabled
Warning: --watch has no effect when used with --fallback-only
Doppler Error: Conflict: unable to specify --no-fallback with --fallback-only

Closes #465
Closes ENG-8748

@rgharris rgharris requested a review from a team as a code owner May 27, 2025 16:37
@rgharris rgharris requested a review from nmanoogian May 27, 2025 16:38
nmanoogian
nmanoogian previously approved these changes May 27, 2025
Copy link
Contributor

@nmanoogian nmanoogian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested lightly and works as expected

This flag can be useful when using the CLI offline as network requests
are not made when only using the fallback file.
@rgharris rgharris merged commit f383368 into master May 28, 2025
29 of 30 checks passed
@rgharris rgharris deleted the rgharris/offline-flag branch May 28, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Offline mode

2 participants