Skip to content

Mr.Mulles TPP freecam config #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SnailPerson wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −6
Open

Mr.Mulles TPP freecam config #2031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ef074
Added Freecam config option
SnailPerson Feb 18, 2026
9a28f3d
Added Freecam config function to systems
SnailPerson Feb 18, 2026
4b84781
Tweaked camera computing fakery to support new config
SnailPerson Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mccore/src/main/java/minecrafttransportsimulator/entities/components/AEntityB_Existing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import minecrafttransportsimulator.sound.SoundInstance;
import minecrafttransportsimulator.systems.CameraSystem;
import minecrafttransportsimulator.systems.CameraSystem.CameraMode;
import minecrafttransportsimulator.systems.ConfigSystem;

/**
* Base class for entities that exist in the world. In addition to the normal functions
Expand Down Expand Up @@ -284,16 +285,17 @@ public boolean updateRider() {
CameraMode cameraMode = InterfaceManager.clientInterface.getCameraMode();
if (CameraSystem.activeCamera == null && cameraMode != CameraMode.FIRST_PERSON) {
riderCameraPosition.set(riderEyePosition);
RotationMatrix cameraRotation = ConfigSystem.client.renderingSettings.freecam_3P.value ? riderRelativeOrientation : rider.getOrientation();

//Adjust eye position to account for zoom settings.
int zoomRequired = 4 + zoomLevel;
riderTempPoint.set(0, 0, cameraMode == CameraMode.THIRD_PERSON ? -zoomRequired : zoomRequired).rotate(rider.getOrientation());
riderTempPoint.set(0, 0, cameraMode == CameraMode.THIRD_PERSON ? -zoomRequired : zoomRequired).rotate(cameraRotation);
riderEyePosition.add(riderTempPoint);

//Check if camera should be where eyes are, or somewhere different.
int cameraZoomRequired = 4 - InterfaceManager.clientInterface.getCameraDefaultZoom() + zoomLevel;
if (zoomRequired != cameraZoomRequired) {
riderTempPoint.set(0, 0, cameraMode == CameraMode.THIRD_PERSON ? -cameraZoomRequired : cameraZoomRequired).rotate(rider.getOrientation());
riderTempPoint.set(0, 0, cameraMode == CameraMode.THIRD_PERSON ? -cameraZoomRequired : cameraZoomRequired).rotate(cameraRotation);
riderCameraPosition.add(riderTempPoint);
} else {
riderCameraPosition.add(riderTempPoint);
Expand Down
4 changes: 3 additions & 1 deletion mccore/src/main/java/minecrafttransportsimulator/jsondefs/JSONConfigClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ public static class JSONRenderingSettings {

public JSONConfigEntry<Boolean> renderWindows = new JSONConfigEntry<>(true, "Should the glass on windows be rendered on vehicles?");
public JSONConfigEntry<Boolean> innerWindows = new JSONConfigEntry<>(false, "Should the glass on windows be rendered on the inside of the vehicle? Note: if renderWindows is false, this config has no effect.");

public JSONConfigEntry<Boolean> freecam_3P = new JSONConfigEntry<>(false, "If true, third-person camera rotation in vehicles is disconnected from vehicle rotation and uses only rider look rotation.");

public JSONConfigEntry<Boolean> renderFlares = new JSONConfigEntry<>(true, "If false, flares on lights will not render.");
public JSONConfigEntry<Boolean> renderBeams = new JSONConfigEntry<>(true, "If false, beams on lights will not render.");

Expand Down Expand Up @@ -86,3 +87,4 @@ public static class ConfigJoystick {
}
}


11 changes: 8 additions & 3 deletions mccore/src/main/java/minecrafttransportsimulator/systems/CameraSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,13 @@ public static boolean adjustCamera(IWrapperPlayer player, Point3D cameraAdjusted
//No custom cameras, check if we are sitting in a seat to adjust orientation.
if (sittingSeat != null) {
cameraAdjustedPosition.set(sittingSeat.prevRiderCameraPosition).interpolate(sittingSeat.riderCameraPosition, partialTicks);
sittingSeat.getInterpolatedOrientation(cameraRotation, partialTicks);
sittingSeat.getRiderInterpolatedOrientation(riderOrientation, partialTicks);
cameraRotation.multiply(riderOrientation);
if (ConfigSystem.client.renderingSettings.freecam_3P.value && InterfaceManager.clientInterface.getCameraMode().thirdPerson) {
sittingSeat.getRiderInterpolatedOrientation(cameraRotation, partialTicks);
} else {
sittingSeat.getInterpolatedOrientation(cameraRotation, partialTicks);
sittingSeat.getRiderInterpolatedOrientation(riderOrientation, partialTicks);
cameraRotation.multiply(riderOrientation);
}
return true;
} else {
//Not doing any camera changes.
Expand Down Expand Up @@ -163,3 +167,4 @@ private CameraMode(boolean thirdPerson) {
}
}
}