Mr.Mulles snowfall_strength variable (again)#2024
Open
SnailPerson wants to merge 3 commits intoDonBruce64:masterfrom
Open
Mr.Mulles snowfall_strength variable (again)#2024SnailPerson wants to merge 3 commits intoDonBruce64:masterfrom
SnailPerson wants to merge 3 commits intoDonBruce64:masterfrom
Conversation
DonBruce64
requested changes
Feb 14, 2026
| if (world.getRainStrength(1.0F) <= 0.0F) { | ||
| return 0.0F; | ||
| } | ||
| if (!world.canSeeSky(pos)) { |
Owner
There was a problem hiding this comment.
I don't think this check is needed? If the block can't see the sky, then it can't rain at the position, so the check above will be false. Also, I'd use world.IsRainingAt and that's a boolean. So if not raining at, retun 0. Same thoughts for all instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this time I actually set up a grade that decided to work with me after the 69th attempt and the 6-7th hour of troubleshooting, no errors in this googoo
@DonBruce64 check it on your end to make sure I didn't produce any doodoo, then merger please, tested it already