タイムアウト時に例外で落ちてしまう問題の修正

src/linkstat/analyzer.py

@@ -38,14 +38,16 @@ def request(url: str) -> AnalyzeResponse:
     :rtype: AnalyzeResponse
     """
     try:
-        res = urlopen(url, timeout=3)
-        return AnalyzeResponse(Result.OK, res.code, res.url, None)
+        with urlopen(url, timeout=3) as res:
+            return AnalyzeResponse(Result.OK, res.code, res.url, None)
     except HTTPError as e:
         # アクセスできて400や500系が来た時はこっち
         return AnalyzeResponse(Result.NG, e.code, url, e.reason)
     except URLError as e:
         # そもそもアクセスすらできなかった場合はこっち
         return AnalyzeResponse(Result.NG, None, url, e.reason)
+    except TimeoutError:
+        return AnalyzeResponse(Result.NG, None, url, "Timeout")
 
 
 def check_links(links: dict[str, URLInfo]) -> list[ReportData]:

tests/test_analyzer.py

@@ -107,3 +107,19 @@ def test_extract_link():
     assert len(duplicated_link_list) == 2
     assert duplicated_link_list[0].url == duplicated_link_list[1].url
     assert duplicated_link_list[0].url == "https://example.com"
+
+
+class TestInValid:
+    @pytest.mark.usefixtures("use_mock_server")
+    def test_request_timeout(self):
+        """タイムアウトの場合、NGになる事"""
+
+        url = "https://httpbin.org/delay/10"
+
+        res = analyzer.request(url)
+
+        assert type(res) is analyzer.AnalyzeResponse
+        assert res.result == "NG"
+        assert res.code is None
+        assert res.url == url
+        assert res.reason == "Timeout"