Skip to content

Conversation

@shivamvijaywargi
Copy link
Contributor

@shivamvijaywargi shivamvijaywargi commented Dec 30, 2025

Summary

There is an issue reported where the search logo is not centered on search/next episode page, these changes makes the logo center on those areas.

Motivation

Better UX

Testing

  • pnpm lint
  • pnpm test
  • Tested on: Android

Screenshots / Video (if UI)

Screenshot_1767102061 Screenshot_1767102102

Closes #43

@shivamvijaywargi
Copy link
Contributor Author

This fixes #43

@Kombustor Kombustor self-assigned this Dec 30, 2025
@Kombustor
Copy link
Contributor

Great, thank you! This definitely solves the bug, but it's still not optimal imo, because of the text wrapping and breaking. We're not space restricted so maybe let's just pull the text from the container so it's not restricted in width and doesn't break? What do you think?

@shivamvijaywargi
Copy link
Contributor Author

shivamvijaywargi commented Dec 30, 2025

Great, thank you! This definitely solves the bug, but it's still not optimal imo, because of the text wrapping and breaking. We're not space restricted so maybe let's just pull the text from the container so it's not restricted in width and doesn't break? What do you think?

That is right and I had the same itch but did not touch it, I was thinking of removing the width from the parent Box element (since the text might not be long enough anyways), let me know your thoughts. Thanks.

I have 2 solutions:

  1. What I mentioned above
  2. Extract the message out of the present Box container, create a new Box container where the existing Box container and message will recide.
    e.g:
<Box>
  <Box>
	Logo
  </Box>
  message
</Box>

@Kombustor
Copy link
Contributor

I think I prefer option 2, should be an easy and straightforward fix. Would you mind implementing that? Thank you!

@shivamvijaywargi
Copy link
Contributor Author

Done, kindly check @Kombustor

@Kombustor
Copy link
Contributor

Would you mind updating the screenshots?

@Kombustor
Copy link
Contributor

Awesome! First contribution 🎉

@shivamvijaywargi
Copy link
Contributor Author

Would you mind updating the screenshots?

Took them but forgot to update 😓 , anyways updated them now, thanks for pointing out.

@Kombustor Kombustor merged commit d82bd1e into DodoraApp:main Dec 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Loading indicator not centered

2 participants