-
Notifications
You must be signed in to change notification settings - Fork 7
fix: center align logo during search/load #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: center align logo during search/load #60
Conversation
|
This fixes #43 |
|
Great, thank you! This definitely solves the bug, but it's still not optimal imo, because of the text wrapping and breaking. We're not space restricted so maybe let's just pull the text from the container so it's not restricted in width and doesn't break? What do you think? |
That is right and I had the same itch but did not touch it, I was thinking of removing the width from the parent Box element (since the text might not be long enough anyways), let me know your thoughts. Thanks. I have 2 solutions:
|
|
I think I prefer option 2, should be an easy and straightforward fix. Would you mind implementing that? Thank you! |
|
Done, kindly check @Kombustor |
|
Would you mind updating the screenshots? |
|
Awesome! First contribution 🎉 |
Took them but forgot to update 😓 , anyways updated them now, thanks for pointing out. |
Summary
There is an issue reported where the search logo is not centered on search/next episode page, these changes makes the logo center on those areas.
Motivation
Better UX
Testing
pnpm lintpnpm testScreenshots / Video (if UI)
Closes #43