Various bugfixes & improvements #11
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements GitHub release notifications and makes several UI improvements and bug fixes across the application. The main addition is a feature that checks for new releases, notifies users, and allows them to download updates directly from GitHub.
Key changes:
- Added GitHub release notification system with modal UI
- Improved video error handling to provide more detailed error messages
- Enhanced UI components with better styling and layout adjustments
- Updated caching strategies for API queries to optimize performance
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/version.ts | New utility functions for version parsing and comparison |
| src/utils/tests/version.test.ts | Test coverage for version utility functions |
| src/hooks/useGithubReleaseNotification.ts | Hook implementing GitHub release check and notification logic |
| src/components/layout/GithubReleaseModal.tsx | Modal component for displaying release notifications |
| src/components/basic/DismissableModal.tsx | Generic dismissable modal component |
| src/components/basic/AppLogo.tsx | Enhanced logo with gradient support |
| src/components/basic/Button.tsx | Added border radius styling |
| src/components/basic/Tag.tsx | Refactored color selection logic |
| src/components/video/UpNextPopup.tsx | Improved layout and removed title requirement |
| src/components/video/RNVideoPlayer.tsx | Enhanced error message composition |
| src/components/media/StreamList.tsx | Removed debug console.log statement |
| src/components/media/EpisodeList.tsx | Layout improvements for horizontal mode |
| src/components/media/ContinueWatchingCard.tsx | Added optional text hiding capability |
| src/app/_layout.tsx | Integrated GitHub release modal |
| src/api/github/* | New GitHub API client, types, and error handling |
| src/api/stremio/hooks.ts | Updated cache timing and added comments |
| package.json, app.config.ts | Version bump to 0.0.2 |
| .github/workflows/main.yaml | Improved build artifact naming with version numbers |
| .github/workflows/github-releases-to-discord.yml | New workflow for Discord notifications |
| .env.example | Added GitHub releases URL configuration |
| README.md | Updated roadmap with completed and planned features |
| right={24} | ||
| top={24} | ||
| gap="s" | ||
| alignItems="center" |
There was a problem hiding this comment.
The parent Box now uses alignItems="center" and justifyContent="center", but these alignment properties may not achieve the intended layout since the Box contains flex children. The previous alignItems="flex-end" was more appropriate for right-aligning the popup contents. Consider whether center alignment is the desired behavior or if this should remain flex-end.
| alignItems="center" | |
| alignItems="flex-end" |
| staleTime: 1000 * 60 * 15, // 15 minutes (streams can change) | ||
| gcTime: 1000 * 60 * 30, // 30 minutes | ||
| retry: 1, | ||
| refetchOnMount: false |
There was a problem hiding this comment.
Setting refetchOnMount: false for streams queries may cause users to see stale stream data when navigating back to a video. Since streams can change (as noted in the comment), consider whether this optimization could negatively impact user experience when stream availability changes.
| refetchOnMount: false | |
| refetchOnMount: true |
No description provided.