fix: Make userinfo_endpoint optional#75
Open
ejmartin504 wants to merge 1 commit intoDockYard:masterfrom
Open
Conversation
ejmartin504
force-pushed
the
userinfo_optional
branch
from
97226a9 to
9852466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #74
This PR simply makes
userinfo_endpointoptional, which makes it possible to validate Apple tokens using their openID configuration.Given that "userinfo_endpoint" is not present in
required_keysI think this is a relatively non-controversial change, and IMO a test does not need to be added here (before, a document without this key would result in an exception, rather than:invalid_documentbeing returned) But happy to add one if needed!(side note: Not particularly important for this PR, but https://github.com/dockyard/styleguides 404s for me. )