POB Update #349
Open
POB Update #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Aingar
commented
Nov 17, 2023
Aingar
commented
- Major performance optimization to health manipulation
- Earhart randomization should now never trigger after a server crash
- Flattening of Dock_Call hook method
- Minor cleanup of unused variables in CoreModule
- /base setshield now only accepts valid numeric input
- Major performance optimization to health manipulation - Earhart randomization should now never trigger after a server crash - Flattening of Dock_Call hook method - Minor cleanup of unused variables in CoreModule - /base setshield now only accepts valid numeric input
dsyalex
requested changes
Dec 5, 2023
| } | ||
|
|
||
| WritePrivateProfileString("Timer", "lastRandomization", itos((int)currTime).c_str(), cfg_filehyperspaceHubTimer.c_str()); | ||
| WritePrivateProfileString("Timer", "lastRandomization", itos((int)(currTime - (currTime % randomizationCooldown))).c_str(), cfg_filehyperspaceHubTimer.c_str()); |
|
|
||
| pub::SpaceObj::SetRelativeHealth(space_obj, base->base_health / base->max_base_health); | ||
|
|
||
| base->baseCSolar = (CSolar*)CObject::Find(space_obj, CObject::CSOLAR_OBJECT); |
Member
There was a problem hiding this comment.
You must call Release on this whenever we bin a PlayerBase object, e.g. probably in basedespawn
dsyalex
reviewed
Dec 5, 2023
| base_shield_reinforcement_threshold = FLT_MAX; | ||
| } | ||
| } | ||
| if (baseCSolar && base_health <= max_base_health) |
Member
There was a problem hiding this comment.
ok but what does this have to do with checking vulnerability windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.