FLHook core optimizations #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyalex
requested changes
Dec 5, 2023
|
|
||
| TRY_HOOK { | ||
| if (iAccepted) | ||
| { // save both chars to prevent cheating in case of server crash |
Member
There was a problem hiding this comment.
Is it safe to remove this? It seems to me that removing this creates an obvious duplication cheat.
- Let's say I have characters A and B in game. Character A has 0 credits and character B has 100 million.
- I use a trade to move 100 million from character B to character A.
- I then take character A, dock it and log it off, saving those credits.
- I then park character B in space and wait for some server crash (or do it myself if I know some behaviour that might trigger one), never having the new character file saved.
- Now I have two characters with 100 million credits.
| LoadUserSettings(iClientID); | ||
|
|
||
| // log | ||
| if (set_bLogConnects) |
| wstring wscIP; | ||
| HkGetPlayerIP(iClientID, wscIP); | ||
|
|
||
| foreach(set_lstBans, wstring, itb) |
Member
There was a problem hiding this comment.
we seem to be getting rid of random things without proper cleanup here - set_lstBans is still defined somewhere
| iPlayers++; | ||
|
|
||
| if (iPlayers > (Players.GetMaxPlayerCount() - set_iReservedSlots)) | ||
| { // check if player has a reserved slot |
Member
There was a problem hiding this comment.
if we're getting rid of the reserved slots functionality altogether, HkSetReservedSlot/CmdSetReservedSlot/HkGetReservedSlot/CmdGetReservedSlot must go too
| #define OBJ_ASTEROID (1 << 29) | ||
|
|
||
|
|
||
| enum EquipmentClass : uint |
Member
There was a problem hiding this comment.
ok but I don't see what this has to do with optimisations
| { | ||
| None = 0, | ||
| LightEquip = 1 << 0, | ||
| AttachedFx = 1 << 1, // contrails |
| ShieldGenerator = 1 << 9, | ||
| Thruster = 1 << 10, | ||
| CargoPod = 1 << 11, | ||
| CloakingDevice = 1 << 12, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes removal of several redundant anticheat checks, or checks that were no longer even use for years.