Logging: logged player death systems are human readable.#336
Open
Aingar wants to merge 1 commit intoDiscoveryGC:masterfrom
Open
Logging: logged player death systems are human readable.#336Aingar wants to merge 1 commit intoDiscoveryGC:masterfrom
Aingar wants to merge 1 commit intoDiscoveryGC:masterfrom
Conversation
dsyalex
requested changes
Nov 13, 2023
Member
dsyalex
left a comment
dsyalex
left a comment
There was a problem hiding this comment.
This PR does more than it says on the tin. Also, since we're apparently abolishing CUSTOM_POB_DOCK_ALERT, shouldn't we get rid of it from the other places it's used too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin Logging player deaths now saves system the death occured in as nickname instead of a numeric hash.
Also removed the incorrectly working BaseLand hook that is replaced by Dock_Call hook that is finalized in #339