Skip to content

feat(graph-proxy): make a container for branch when push #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teoching0705 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

feat(graph-proxy): make a container for branch when push #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/_graph_proxy_container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
images: ${{ env.IMAGE_REPOSITORY }}
tags: |
type=raw,value=${{ steps.tags.outputs.version }}
type=raw,value=${{ github.ref_name }}
type=raw,value=latest
Copy link
Collaborator

@davehadley davehadley Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a branch is pushed, will this also overwrite latest?

If so, I don't think that's what we want. We want latest to always point to the latest tag.
It latest is overwritten with branch containers, if someone tries to pull graph-proxy:latest they might get your probably broken branch container. Which is probably not what you intend.


- name: Set up Docker Buildx
Expand All @@ -47,7 +48,7 @@ jobs:
context: backend
file: backend/Dockerfile.graph-proxy
target: deploy
push: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/graph-proxy@') }}
push: ${{ github.event_name == 'push' && (github.ref_type == 'branch' || startsWith(github.ref, 'ref/tags/graph-proxy@')) }}
Copy link
Collaborator

@davehadley davehadley Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refs changed to ref.
Is this a typo?

load: ${{ !(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/graph-proxy@')) }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Expand Down