Add signal generator device #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
TODO: Add tests |
Collaborator
|
I like having the edm ui but I don't think it belongs here. I don't really want anything in here that needs external setup and config to be run. In which case I'd suggest moving the signal generator and screen to tickit-devices, and just making this pr the relevant changes to epics adapter. |
abbiemery
requested changes
Nov 23, 2023
Collaborator
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
See previous comment.
Contributor
Author
|
Have moved to tickit devices DiamondLightSource/tickit-devices#99 and created a new PR for the epics adapter changes: #198. So will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: