Skip to content

Conversation

@tomkane-dls
Copy link
Collaborator

Updated _generate_json_map:

  • display names are now taken from .bob files and added to the json map
  • display_name = <name> tag if present, if not display_name = filepath tail without file extension, if not display_name = null (using _parse_display_name)
  • if duplicate display names for children they are enumerated (cam 1, cam 2 etc.) (using _fix_duplicate_names)

Additionally:

  • removed 'visited' logic and just traverse bob files multiple times if needed
  • added more comments to _generate_json_map
  • moved _get_macros from to flatten class
  • commented out visited node test
  • adjusted tests/example json with relevant display names or None so that they pass

@tomkane-dls tomkane-dls requested a review from OCopping January 14, 2026 13:58
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (7f6b5c0) to head (1f8df22).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/techui_builder/builder.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   89.41%   89.66%   +0.25%     
==========================================
  Files           9        9              
  Lines         737      755      +18     
==========================================
+ Hits          659      677      +18     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomkane-dls
Copy link
Collaborator Author

I just saw the coverage report - do you want me to add new tests?

@tomkane-dls
Copy link
Collaborator Author

Updated parse_display_names to reject empty name tag
Removed commented out tests
Added four tests:

  • test_parse_display_name_with_name
  • test_parse_display_name_from_filepath
  • test_parse_display_name_returns_none
  • test_fix_duplicate_names_recursive

@tomkane-dls tomkane-dls requested review from niamhdougan and removed request for OCopping January 15, 2026 11:21
@tomkane-dls tomkane-dls merged commit 9fb84c2 into main Jan 16, 2026
8 checks passed
@tomkane-dls tomkane-dls deleted the json-display-names branch January 16, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants