fix: Unsubscribe from events when worker stops #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 94.58% 94.59%
=======================================
Files 41 41
Lines 2587 2588 +1
=======================================
+ Hits 2447 2448 +1
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@tpoliaw for completeness is it worth also cleaning up this subscription in this teardown function? |
Contributor
Author
|
Possibly. It's a bit more awkward there with the current design because there's nowhere to hold the subscription. I'll have a look at what can be done. This is all about to change in #1200 so it might be easier to do it there. |
callumforrester
approved these changes
Sep 17, 2025
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
I'll approve here then and leave it to you where you put the change.
tpoliaw
changed the title
tpoliaw
force-pushed
the
unsubscribe
branch
from
9faec8d to
3991840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.