Skip to content

Set AttrW after Put in pva transport #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GDYendell merged 5 commits into from
Jan 14, 2026
Merged

Set AttrW after Put in pva transport #292

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8f3f84
chore: set sync_setpoint to True after put
shihab-dls Dec 16, 2025
eceea0e
refactor: cast value depending on attrW datatype
shihab-dls Dec 16, 2025
9fcd28b
refactor: error on op.done if attr_w put fails
shihab-dls Jan 14, 2026
47e7858
Merge branch 'main' into sync_setpoit_after_put
shihab-dls Jan 14, 2026
f218649
refactor: switch around pv.post and op.done so setpoint is set before…
shihab-dls Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/fastcs/transports/epics/pva/_pv_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from p4p.server.asyncio import SharedPV

from fastcs.attributes import Attribute, AttrR, AttrRW, AttrW
from fastcs.datatypes import Table
from fastcs.datatypes import Enum, Table
from fastcs.methods import CommandCallback
from fastcs.tracer import Tracer

Expand Down Expand Up @@ -47,6 +47,12 @@ async def put(self, pv: SharedPV, op: ServerOperation):
cast_value = cast_from_p4p_value(self._attr_w, raw_value)

tracer.log_event("PV put", topic=self._attr_w, pv=pv, value=cast_value)

if isinstance(self._attr_w.datatype, Enum):
pv.post(cast_to_p4p_value(self._attr_w, cast_value))
else:
pv.post(value)

await self._attr_w.put(cast_value)
op.done()

Expand Down