Skip to content

Conversation

@KoviRobi
Copy link
Contributor

@KoviRobi KoviRobi commented Apr 5, 2025

It was accidentally typoed in 32c4233 which moved it. This made it impossible to disable highlight-inset, and use highlight-outset instead.

-  let highlight-inset = (
-    __codly-args.highlight-inset.type_check
-  )(if "highlight-inset" in extra {
-    extra.highlight-inset
-  } else {
-    state("codly-highlight-inset", __codly-args.highlight-inset.default).get()
-  })
+  let highlight-inset = (
+    __codly-args.highlight-inset.type_check
+  )(if "highlight-inset" in extra {
+    extra.highlight-inset
+  } else {
+    state("highlight-inset", __codly-args.highlight-inset.default).get()
+  });

I have updated the test to make it more obvious what it is testing
1

Feel free to not take the whitespace clean commit -- my editor does it automatically and it's easiest to throw away (and review) if I do it in a separate commit (and if it's the first, it means I can edit later and then will only throw it away as the last thing).

@Dherse
Copy link
Owner

Dherse commented Apr 10, 2025

Ugh what a stupid bug, thanks a lot! I need to do a double check over all of the states that they're correct eventually 😭

@Dherse Dherse merged commit d62be51 into Dherse:main Apr 10, 2025
1 check passed
@Dherse
Copy link
Owner

Dherse commented Apr 10, 2025

Thank you very much! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants