-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement Redfish API v1 Systems and FirmwareInventory endpoints #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nmgaston, looking good so far. Couple questions:
- Are we planning to keep the base /api part for redfish? when you click on the odata.ids in postman for example, none of them work because they dont have that
/apiprefix. Example:
{
"@odata.id": "/redfish/v1/Systems",
"@odata.type": "#ComputerSystemCollection.ComputerSystemCollection",
"Members": [
{
"@odata.id": "/redfish/v1/Systems/744025c9-df9d-4766-9424-213a7517e6c0" <--hyperlink here doesnt work
}
],
"Members@odata.count": 1,
"Name": "Computer System Collection"
}-
Running the validator, im having trouble getting the auth to work, i have tried:
python RedfishServiceValidator.py --authtype Token --token <token>-r http://<host>/api
and
python RedfishServiceValidator.py -u <username> -p <password> -r http://<host>/api
I get 401s for both of those, (not including the /api causes 404 not founds). -
Re: Architecture - I know i did everything in the same file for the POC, but eventually want to follow same architecture as the rest of the app - breaking out the http portion from the parsing/logic and putting that in the business layer. Additionally, If we're thinking long term maintainability -- i dont know that leveraging reflection is gonna be the best way forward, ideally we type what we can or leverage existing go modules that might already have types for redfish. For now, I think we make a conscious decision that we're good for a POC as is, but come time to merge this to the main repo, I think these are the two main things that would need to get addressed before that happens and gets officially released.
|
2. Running the validator, im having trouble getting the auth to work, i have tried: @rsdmike - We don't have authorization done yet that will work with the tools. We've had to turn off the authentication and authorization. The steps are outlined here: https://jira.devtools.intel.com/browse/CM-32, but I'll add them below too.
cd /home/nat/git/Redfish-Service-Validator && python3 RedfishServiceValidator.py
|
@rsdmike - Makes sense. We can do a refactor after we get this main development done and before merging it into main. |
Adds complete DMTF Redfish v1.0.0 compliance with FirmwareInventory endpoints for Intel AMT device management.