Merged
Conversation
… playwright-test-remove-member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've already reviewed this code together so I'm not gonna spell out the functionality here. What we discussed ended up working just fine.
The thing I banged my head against for 45 mins before succeeding was that the execution of not.toSeeContact on line 92 of auth.test.ts runs a long time on my machine (~20 seconds). This was tipping my machine over the 30 second playright timeout and the test was failing. The error fail message clearly indicated a timeout - but I assumed that my code was wrong as I could comment out line 92 and the test succeeded and put it back in and the test failed. Ergo I spent a bunch of time trying to debugging my test and the toSeeContact function. In the end I was able to simply increase the playwright test timeout setting and everything works. I'm totally open to discussing this however