Instance Export: Fix script signing#11
Merged
bigdogwillfeed merged 4 commits intomainfrom Mar 5, 2025
Merged
Conversation
This should help with the signing process, because the code signing certificate can now be trusted :crossed-fingers:
fredrodlima
approved these changes
Mar 5, 2025
Contributor
fredrodlima
left a comment
fredrodlima
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this enhancement here NG!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code signing certificate was out of date, but CI didn't tell us that signing wasn't working. So I made some changes to the signing script so that it fails if the resulting signature isn't valid. This requires the DevResultsRoot certificate to be a trusted root certificate, so I added that to the repository secrets and CI file as well. Then I created a new signing certificate and put that in the secrets and Google drive
You can see that CI works on https://github.com/DevResults/DevResultsTools/actions/runs/13662472413/job/38196556984 (and you can see other previous runs failed when not everything was correctly in place)
To test, you can download the artifact from the latest run, unzip it, and confirm the signature is valid with
Get-AuthenticodeSignature .\InstanceExport.ps1. This will only return valid if you've also installed the DevResultsRoot certificate into your "trusted root certificates". The cer file is in google drive https://drive.google.com/file/d/1-0M8SW_Y-b4C2GPhe_OauTmwnBINop3T/view?usp=drive_link if you need it.I also updated the README to point to the signed script (stored in a release) but that link will only be valid once we merge this and tag a new release -- there's not a good way to point to files in the most recent release (the best I can do is point to the latest release where folks can choose the file, but a direct link from the README seemed kinder)