Conversation
Our powershell 5 version doesn't work on non-windows computers, and the powershell 7 version doesn't work on powershell 5... This seems like a reasonable balance for something we've had several help tickets on
This gives users the option to download the signed version (vs run unsigned)
v3 was deprecated in January
brentkeller
approved these changes
Mar 4, 2025
Member
brentkeller
left a comment
There was a problem hiding this comment.
This looks good to me. I checked the password handling in powershell 5.1 and 7.5 in Windows and in 7.5 on Ubuntu and the string was parsed properly each time. I wasn't able to reach the API from my Ubuntu session but that seems like a different networking issue because curl couldn't connect either.
Thanks for adding the piece for releasing as well, that seems really helpful 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had tickets on two things recently:
For problem 1, this builds on #9 by trying both ways to get the password in plain text. If neither of those work, we fall back to prompting for a plain text string... end result is folks shouldn't be blocked from logging in by their powershell version/environment
For problem 2, this builds on #4 by publishing the signed script as a release (instead of an artifact). Releases are generally easier to find, and are retained longer (artifacts are for only 90 days)
To test:
If that all works and seems nice, we'll tag and generate a release for further testing