Skip to content

Comments

Improve Export Script#10

Merged
bigdogwillfeed merged 3 commits intomainfrom
export-updates
Mar 4, 2025
Merged

Improve Export Script#10
bigdogwillfeed merged 3 commits intomainfrom
export-updates

Conversation

@bigdogwillfeed
Copy link
Member

We've had tickets on two things recently:

  1. script no longer works on powershell 5
  2. script is unsigned

For problem 1, this builds on #9 by trying both ways to get the password in plain text. If neither of those work, we fall back to prompting for a plain text string... end result is folks shouldn't be blocked from logging in by their powershell version/environment

For problem 2, this builds on #4 by publishing the signed script as a release (instead of an artifact). Releases are generally easier to find, and are retained longer (artifacts are for only 90 days)

To test:

  1. create a manifest
  2. run the export script in powershell 5
  3. run the export script in powershell 7
  4. if you've got an environment where Improve how the $password is converted to plain text #9 was a fix, run the export script there

If that all works and seems nice, we'll tag and generate a release for further testing

Our powershell 5 version doesn't work on non-windows computers, and the powershell 7 version doesn't work on powershell 5... This seems like a reasonable balance for something we've had several help tickets on
This gives users the option to download the signed version (vs run unsigned)
Copy link
Member

@brentkeller brentkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I checked the password handling in powershell 5.1 and 7.5 in Windows and in 7.5 on Ubuntu and the string was parsed properly each time. I wasn't able to reach the API from my Ubuntu session but that seems like a different networking issue because curl couldn't connect either.

Thanks for adding the piece for releasing as well, that seems really helpful 👍

@bigdogwillfeed bigdogwillfeed merged commit f5c2f5a into main Mar 4, 2025
1 check passed
@bigdogwillfeed bigdogwillfeed deleted the export-updates branch March 4, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants