Group by - solution to example 3 changed#15
Open
frenchmomsecrets wants to merge 2 commits intoDevMountain:masterfrom
Open
Group by - solution to example 3 changed#15frenchmomsecrets wants to merge 2 commits intoDevMountain:masterfrom
frenchmomsecrets wants to merge 2 commits intoDevMountain:masterfrom
Conversation
Changed lines 428 and 429 left table changed from 'album' to 'artist' and afterwards join on 'album' this way we have all the artists, even those that don't have any album (as per the exercise stated: " Find a list of *all* artists and how many albums they have" otherwise in the proposed solution we only have the artist we have at least 1 album.
Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the left table to: artist and afterwards joining on table: album
this way we get all the artists, even those who have 0 albums, since instructions stated: "Find a list of all artists and how many albums they have"
Otherwise we only get the artists who have at least 1 album.