-
Notifications
You must be signed in to change notification settings - Fork 16
Challenge/ivanilson santos #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nilson98bra
wants to merge
17
commits into
DevMagic:master
Choose a base branch
from
nilson98bra:challenge/ivanilson-santos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Challenge/ivanilson santos #21
nilson98bra
wants to merge
17
commits into
DevMagic:master
from
nilson98bra:challenge/ivanilson-santos
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation of the server, folders and connection with lol api.
The database structure and the connection has been made.
Verification of blank values and checking of emails already registered in the database, in addition to the basic function: registration of users in the database
Login functionality created, with verification of blank values. A session token is send to the client.
Verification of blank field; if the summoner name exist in LoL database or if exists in this application's database. There's also been a bit of change regarding "async/await" and "then".
There are verification of blank field and if id exist in this aplication's database.
There are verification of blank fields and if id exist in this aplication's database. Updating summoners can only be done by the user associated with it. Fixed the summoners removal and creation endpoints. User id was not being saved and removal of summoners can only be done by the user associated with it.
Feature created to download a xlsx file with all information of summoners with a numbers of wins and losses
Feature create to search and filter summoners by summonerName, summonerLevel, wins and losses
An error handling function was created, which eliminated many lines of code with decision structure. It was also created several more environments for the system to be used in other environments without problems. Updated instructions for handling the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend-challenge completo.