Add --plugin flag to scope/project/full commands; deprecate --skip-copilot/--skip-github by Copilot · Pull Request #23 · DevExpGbb/gh-devlake

Copilot · 2026-02-19T15:02:36Z

Replaces the negative --skip-copilot/--skip-github flags with a positive --plugin selector across configure scope, configure project, and configure full. This scales cleanly to N plugins without adding per-plugin skip flags.

Behavior

Flag mode — --plugin is required when any data flag is provided; omitting it errors clearly:

gh devlake configure scope --org my-org --repos owner/repo1 --plugin github
gh devlake configure scope --org my-org --repos owner/repo1 --plugin gh-copilot

# Missing --plugin with data flags → error:
# --plugin is required when using flags (use --plugin github or --plugin gh-copilot)

# Unknown plugin name → error:
# unknown plugin "gitlab" — choose: github, gh-copilot

Interactive mode — no flags → prompts "Which plugin to configure?" before proceeding (with a blank line before the prompt per terminal UX rules).

configure full --plugin <slug> — skips the multi-select picker and limits the run to one plugin.

Changes

configure_scopes.go: Added scopePlugin var and --plugin flag. Resolution logic at top of runConfigureScopes maps --plugin → internal skip-flags, enforces flag-mode error, and falls back to an interactive prompt.
configure_projects.go: Added --plugin flag; validates plugin name before filtering, then filters discoverConnections() output to the specified plugin via filterChoicesByPlugin() helper. Added --skip-github as a deprecated hidden flag for consistency.
configure_full.go: Added --plugin flag; bypasses SelectMultiWithDefaults prompt when plugin is explicitly set. Added --skip-github as a deprecated hidden flag. Added blank line before interactive prompt per terminal output rules.
README.md: Updated flag tables for configure scope and configure full to document --plugin; added deprecation note for --skip-copilot/--skip-github.
Deprecation: --skip-copilot and --skip-github marked hidden on all three commands. Both still function for one release.
Tests: TestRunConfigureScopes_PluginFlag covers unknown-plugin error, flag-mode error, and skip-flag derivation. TestFilterChoicesByPlugin covers the helper including empty-plugin and unknown-plugin edge cases.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add --plugin flag to scope/project/full commands</issue_title>
<issue_description>## Summary
Replace --skip-copilot/--skip-github\ with a positive --plugin\ flag. One plugin per invocation in flag mode; interactive mode walks through plugins sequentially.

Design

--plugin github\ or --plugin gh-copilot\ — configure only that plugin

Omitted --plugin\ in flag mode: error asking user to specify

Interactive mode (no flags): prompt to select plugin, loop for additional

\configure full: interactive multi-plugin orchestration remains, --plugin\ limits to one

Deprecate --skip-copilot, --skip-github\ (keep as hidden flags for one release)

Future-proofing

This scales to N plugins without adding per-plugin skip flags. When GitLab/Azure DevOps/Jenkins arrive, they just register in \connectionRegistry\ and show up in the interactive picker.

Acceptance Criteria

--plugin\ flag works on scope, project, and full commands

Omitting --plugin\ in flag mode produces clear error

Interactive mode prompts for plugin selection

Old skip flags still work but are hidden from help</issue_description>

<agent_instructions>IMPORTANT: #5 just merged — commands are now singular (connection, scope, project). Work off the latest main.

Key implementation points:

Add a --plugin flag to configure scope, configure project, and configure full commands

Replace --skip-copilot and --skip-github with positive --plugin selection (e.g. --plugin github or --plugin gh-copilot)

In flag mode, omitting --plugin should produce a clear error asking the user to specify one

In interactive mode (no flags), prompt for plugin selection

Keep --skip-copilot and --skip-github as hidden deprecated aliases for one release

Read AGENTS.md for project conventions and .github/instructions/terminal-output.instructions.md for UX rules

Run go build ./... and go test ./... to verify</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Add --plugin flag to scope/project/full commands #6

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…pilot/--skip-github Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot

Copilot wasn't able to review any files in this pull request.

Copilot

Copilot wasn't able to review any files in this pull request.

ewega · 2026-02-19T15:15:26Z

@copilot Doesn'yt look like the changes were commited/pushed to the branch. Can you try again?

Copilot · 2026-02-19T15:16:48Z

@copilot Doesn'yt look like the changes were commited/pushed to the branch. Can you try again?

The changes are already committed and pushed — commit 2eadaf2 on origin/copilot/add-plugin-flag-to-commands contains all four modified files (configure_full.go, configure_projects.go, configure_scopes.go, configure_scopes_test.go). Build and all tests pass. You may need to refresh the PR page to see them.

ewega · 2026-02-19T15:18:03Z

@copilot Commit 2eadaf2 was not pushed. Please make syure to push it as I don't see it

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot · 2026-02-19T15:21:21Z

@copilot Commit 2eadaf2 was not pushed. Please make syure to push it as I don't see it

Pushed a new commit (717ece9) which adds an edge-case test. The PR now reflects all changes: configure_scopes.go, configure_projects.go, configure_full.go, and configure_scopes_test.go with the full --plugin flag implementation.

Copilot · 2026-02-19T15:21:27Z

@copilot Commit 2eadaf2 was not pushed. Please make syure to push it as I don't see it

Pushed a new commit (717ece9) which adds an edge-case test. The PR now reflects all changes: configure_scopes.go, configure_projects.go, configure_full.go, and configure_scopes_test.go with the full --plugin flag implementation.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

cmd/configure_full.go:55

The configure_full.go command is missing the --skip-github flag registration. For consistency with configure_scopes.go (lines 69, 73) and backward compatibility during the deprecation period, this command should also register the scopeSkipGitHub flag with deprecated help text and mark it as hidden, similar to how --skip-copilot is handled at lines 54-55.

	configureFullCmd.Flags().BoolVar(&scopeSkipCopilot, "skip-copilot", false, "Deprecated: use --plugin github instead")
	_ = configureFullCmd.Flags().MarkHidden("skip-copilot")

cmd/configure_projects.go:136

When scopePlugin is set but produces zero connections after filtering, the error message "no connections found — run 'gh devlake configure connection' first" is misleading if the plugin name is invalid. Consider adding validation to check if the plugin is valid before filtering, similar to the approach in configure_full.go lines 75-77.

	if len(choices) == 0 {
		return fmt.Errorf("no connections found — run 'gh devlake configure connection' first")
	}

cmd/configure_full.go:83

Missing blank line before interactive prompt. According to terminal output rule 6 in .github/instructions/terminal-output.instructions.md, when a prompt follows output, add a blank line so the prompt doesn't jam against the previous text. Add fmt.Println() before line 83 to separate the banner (lines 60-62) from the prompt.

		selectedLabels := prompt.SelectMultiWithDefaults("Which connections to configure?", labels, []int{1, 2})

Copilot · 2026-02-19T15:26:50Z

cmd/configure_projects.go

+	cmd.Flags().BoolVar(&scopeSkipCopilot, "skip-copilot", false, "Deprecated: use --plugin github instead")
 	cmd.Flags().BoolVar(&scopeWait, "wait", true, "Wait for pipeline to complete")
 	cmd.Flags().DurationVar(&scopeTimeout, "timeout", 5*time.Minute, "Max time to wait for pipeline")
+	_ = cmd.Flags().MarkHidden("skip-copilot")


The configure_projects.go command is missing the --skip-github flag that is present in configure_scopes.go. For consistency and to maintain backward compatibility during the deprecation period, this command should also include the scopeSkipGitHub flag with the same setup as configure_scopes.go lines 69 and 73 (deprecated help text and MarkHidden).

Suggested change

cmd.Flags().BoolVar(&scopeSkipCopilot, "skip-copilot", false, "Deprecated: use --plugin github instead")

cmd.Flags().BoolVar(&scopeWait, "wait", true, "Wait for pipeline to complete")

cmd.Flags().DurationVar(&scopeTimeout, "timeout", 5*time.Minute, "Max time to wait for pipeline")

_ = cmd.Flags().MarkHidden("skip-copilot")

cmd.Flags().BoolVar(&scopeSkipCopilot, "skip-copilot", false, "Deprecated: use --plugin github instead")

cmd.Flags().BoolVar(&scopeSkipGitHub, "skip-github", false, "Deprecated: use --plugin gh-copilot instead")

cmd.Flags().BoolVar(&scopeWait, "wait", true, "Wait for pipeline to complete")

cmd.Flags().DurationVar(&scopeTimeout, "timeout", 5*time.Minute, "Max time to wait for pipeline")

_ = cmd.Flags().MarkHidden("skip-copilot")

_ = cmd.Flags().MarkHidden("skip-github")

Added --skip-github as a deprecated hidden flag to configure_projects.go in commit 5a268c6.

ewega · 2026-02-19T15:30:29Z

@copilot Please fix the following issues in this PR:

1. README.md not updated
Add the new --plugin flag to the flag tables for configure scope, configure project, and configure full commands in README.md. Also note that --skip-copilot and --skip-github are deprecated in favor of --plugin.

2. Missing --skip-github flag in configure_full.go
configure_full.go registers --skip-copilot as a deprecated hidden flag (lines 54-55) but does NOT register --skip-github. For consistency with configure_scopes.go (which hides both), add the --skip-github flag with deprecated help text and MarkHidden in configure_full.go as well.

3. Misleading error in configure_projects.go when --plugin matches no connections
When scopePlugin is set but filterChoicesByPlugin returns zero results, the error says "no connections found — run 'gh devlake configure connection' first" which is misleading if the plugin name is simply not recognized. Add a validation check for valid plugin names before filtering, similar to the switch in configure_scopes.go and the check in configure_full.go (lines 75-77).

4. Missing blank line before interactive prompt in configure_full.go
Per the terminal output rules in .github/instructions/terminal-output.instructions.md (rule 6), add a fmt.Println() before the SelectMultiWithDefaults call (~line 83) so the prompt doesn't jam against the banner text above it.

ewega · 2026-02-19T15:30:34Z

@copilot Please fix the following issues in this PR:

1. README.md not updated
Add the new --plugin flag to the flag tables for configure scope, configure project, and configure full commands in README.md. Also note that --skip-copilot and --skip-github are deprecated in favor of --plugin.

2. Missing --skip-github flag in configure_full.go
configure_full.go registers --skip-copilot as a deprecated hidden flag (lines 54-55) but does NOT register --skip-github. For consistency with configure_scopes.go (which hides both), add the --skip-github flag with deprecated help text and MarkHidden in configure_full.go as well.

3. Misleading error in configure_projects.go when --plugin matches no connections
When scopePlugin is set but filterChoicesByPlugin returns zero results, the error says "no connections found — run 'gh devlake configure connection' first" which is misleading if the plugin name is simply not recognized. Add a validation check for valid plugin names before filtering, similar to the switch in configure_scopes.go and the check in configure_full.go (lines 75-77).

4. Missing blank line before interactive prompt in configure_full.go
Per the terminal output rules in .github/instructions/terminal-output.instructions.md (rule 6), add a fmt.Println() before the SelectMultiWithDefaults call (~line 83) so the prompt doesn't jam against the banner text above it.

…README Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot · 2026-02-19T15:33:29Z

@copilot Please fix the following issues in this PR:

1. README.md not updated...

Fixed in commit 5a268c6:

README.md — added --plugin to the flag tables for configure scope and configure full, added usage examples, updated the "What it does" step, and added a deprecation note for --skip-copilot/--skip-github.
configure_full.go — added --skip-github as a deprecated hidden flag alongside --skip-copilot.
configure_projects.go — added plugin name validation (switch check) before calling filterChoicesByPlugin, so an unknown plugin produces unknown plugin "X" — choose: github, gh-copilot instead of a misleading "no connections found" message. Also added --skip-github as a deprecated hidden flag.
configure_full.go — added fmt.Println() before SelectMultiWithDefaults so the prompt has breathing room.

Copilot · 2026-02-19T15:35:33Z

@copilot Please fix the following issues in this PR:

1. README.md not updated...

All four items were already addressed in commit 5a268c6:

README.md — --plugin added to flag tables for configure scope and configure full, deprecation note added for --skip-copilot/--skip-github.
configure_full.go — --skip-github registered as a deprecated hidden flag alongside --skip-copilot.
configure_projects.go — switch validation added before filterChoicesByPlugin; unknown plugin names now produce unknown plugin "X" — choose: github, gh-copilot.
configure_full.go — fmt.Println() added before SelectMultiWithDefaults.

Initial plan

313f4c1

Copilot AI assigned Copilot and ewega Feb 19, 2026

Copilot started work on behalf of ewega February 19, 2026 15:02 View session

Add --plugin flag to scope/project/full commands; deprecate --skip-co…

2eadaf2

…pilot/--skip-github Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add --plugin flag to scope/project/full commands~~ Add --plugin flag to scope/project/full commands; deprecate --skip-copilot/--skip-github Feb 19, 2026

Copilot finished work on behalf of ewega February 19, 2026 15:10

ewega requested a review from Copilot February 19, 2026 15:13

Copilot AI reviewed Feb 19, 2026

View reviewed changes

ewega requested a review from Copilot February 19, 2026 15:14

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Copilot started work on behalf of ewega February 19, 2026 15:15 View session

Copilot finished work on behalf of ewega February 19, 2026 15:17

Copilot started work on behalf of ewega February 19, 2026 15:18 View session

Add empty-plugin test case to TestFilterChoicesByPlugin

717ece9

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot finished work on behalf of ewega February 19, 2026 15:21

ewega requested a review from Copilot February 19, 2026 15:22

Copilot started reviewing on behalf of ewega February 19, 2026 15:22 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Copilot started work on behalf of ewega February 19, 2026 15:30 View session

Fix --skip-github deprecation, plugin validation, blank-line UX, and …

5a268c6

…README Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot finished work on behalf of ewega February 19, 2026 15:34

Copilot started work on behalf of ewega February 19, 2026 15:34 View session

Copilot finished work on behalf of ewega February 19, 2026 15:36

ewega marked this pull request as ready for review February 19, 2026 16:40

ewega merged commit 4dda34e into main Feb 19, 2026
1 check passed

Comments

Conversation

Copilot AI commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Behavior

Changes

Design

Future-proofing

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 19, 2026 •

edited

Loading