-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Deps #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Deps #55
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refreshes selected runtime and development dependencies in package.json (and the corresponding pnpm-lock.yaml) to newer minor/patch versions, keeping the build, testing, and app runtime stack current without changing application code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:56` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"rollup-plugin-copy": "3.4.0",
</code_context>
<issue_to_address>
**issue (testing):** Align jest-environment-jsdom major version with the Jest runtime to avoid subtle test/runtime mismatches.
jest is still on ^29.7.0 while jest-environment-jsdom is ^30.2.0, which is a major-version mismatch. The env packages usually track Jest’s major and may depend on internal APIs that change between majors, so this can cause flaky or failing tests. Consider either keeping jest-environment-jsdom on a 29.x version or upgrading Jest to 30.x at the same time.
</issue_to_address>
### Comment 2
<location> `package.json:61` </location>
<code_context>
"slugify": "^1.6.6",
- "styled-components": "^6.1.19",
+ "styled-components": "^6.2.0",
"ts-jest": "^27.1.5",
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
</code_context>
<issue_to_address>
**suggestion (testing):** Check ts-jest compatibility with the newer TypeScript 5.9.x version.
ts-jest is still on ^27.1.5 while TypeScript is ^5.9.3. That TS version is likely outside the peer range ts-jest 27 was validated against, which can cause test compilation/type-checking issues. Please verify ts-jest’s supported TypeScript versions and either upgrade ts-jest or adjust the TypeScript version to a compatible range.
```suggestion
"ts-jest": "^29.2.5",
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates multiple dependencies and devDependencies to their latest minor or patch versions, focusing on bug fixes, security patches, and new features. The updates include core React libraries, Sentry monitoring, SWC compiler tooling, testing libraries, and build tools.
Key Changes:
- Core dependency updates:
@deskpro/deskpro-ui,@sentry/*,@tanstack/react-query,react-hook-form,react-router-dom - DevDependency updates:
@swc/core,@swc/helpers,@types/react,jest-environment-jsdom,styled-components,typescript,vite - Lock file synchronized with package.json changes
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency versions for core libraries and development tools |
| pnpm-lock.yaml | Automatically generated lock file reflecting the updated dependency tree |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 2c1db83 deployed to: https://woocommerce-pr-55.ci.next.deskprodemo.com URLs: |
This pull request updates several dependencies and devDependencies in the
package.jsonfile to their latest minor or patch versions. These updates help keep the project up-to-date with bug fixes, security patches, and new features from upstream libraries.Dependency updates:
@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,react-hook-form, andreact-router-domto newer versions for improved stability and new features.@swc/core,@swc/helpers,@types/react,jest-environment-jsdom,styled-components,typescript, andviteto their latest compatible versions for better development experience and compatibility. [1] [2]Summary by Sourcery
Update application and tooling dependencies to their latest compatible minor and patch versions.
Build: